[14.5-stable] pkg/debug: fix COM port detection#5890
Open
christoph-zededa wants to merge 2 commits intolf-edge:14.5-stablefrom
Open
[14.5-stable] pkg/debug: fix COM port detection#5890christoph-zededa wants to merge 2 commits intolf-edge:14.5-stablefrom
christoph-zededa wants to merge 2 commits intolf-edge:14.5-stablefrom
Conversation
Newer kernels no longer expose /sys/class/tty/*/device/resources. Switch to reading port and IRQ directly from the per-tty sysfs files /sys/class/tty/*/port and /sys/class/tty/*/irq. On x86_64, a port value of 0x0 indicates no hardware is present and the entry is skipped. The IO port range is computed as base to base+7 to match the standard 8-byte UART register window. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Christoph Ostarek <christoph@zededa.com> (cherry picked from commit d4449f4)
after spec.sh fix Signed-off-by: Christoph Ostarek <christoph@zededa.com> (cherry picked from commit 8d72d88)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 14.5-stable #5890 +/- ##
===============================================
+ Coverage 24.97% 32.62% +7.64%
===============================================
Files 8 9 +1
Lines 1185 1122 -63
===============================================
+ Hits 296 366 +70
+ Misses 820 675 -145
- Partials 69 81 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Based on #5876
Newer kernels no longer expose /sys/class/tty//device/resources. Switch to reading port and IRQ directly from the per-tty sysfs files /sys/class/tty//port and /sys/class/tty/*/irq.
On x86_64, a port value of 0x0 indicates no hardware is present and the entry is skipped. The IO port range is computed as base to base+7 to match the standard 8-byte UART register window.
Qemu tests:
Effect on EVE master:
4 COM ports are detected, instead of 0
Effect on EVE 14.5:
4 COM ports are detected, instead of 1
This is because the serial port connected via PCI was detected, but not the ones via uart8250.
How to test and validate this PR
Run
spec.shand check that all COM ports are printed.Changelog notes
Fix COM port detection in spec.sh
Also, to the PRs that should be backported into any stable branch, please
add a label
stable.Checklist
For backport PRs (remove it if it's not a backport):
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.