You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Have you check all functionality provided by pgcenter on ARM?
I am asking because I am not ARM-user and I don't have ARM devices - if some problems will occur on ARM users I unable to reproduce and handle bugs. Due to this I'd disinclined to take responsibility about proper work on platforms other than x86_64, and this is why there is only amd64 arch in build configuration.
It's quite easy to add new arch, but I must be completely sure that resulting binary will work correctly.
Now, about to PR, you added arm arch to goreleaser configuration. But besides of packages, this repo also has CI pipeline (Github Actions) and provides instructions for building docker images. If you want to implement ARM, you need to add CI instructions (see .github directory) for ARM, change existing docker builds instructions and add build instructions for amd64 and arm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for arm builds.