Skip to content

✨Add support to TSImportType#14

Open
adrielcodeco wants to merge 1 commit intoleonardfactory:masterfrom
adrielcodeco:master
Open

✨Add support to TSImportType#14
adrielcodeco wants to merge 1 commit intoleonardfactory:masterfrom
adrielcodeco:master

Conversation

@adrielcodeco
Copy link
Copy Markdown

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 7, 2019

Codecov Report

Merging #14 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #14      +/-   ##
=========================================
+ Coverage   91.89%   92.1%   +0.21%     
=========================================
  Files           4       4              
  Lines         111     114       +3     
  Branches       41      41              
=========================================
+ Hits          102     105       +3     
  Misses          9       9
Impacted Files Coverage Δ
src/metadata/serializeType.ts 90.14% <100%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b22f3...d8dbfbf. Read the comment docs.

* This is resolved in main plugin method, calling
* `path.scope.crawl()` which updates the bindings.
*/
const reference = serializeReference(node.qualifier!);
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort! I'd like to know here when qualifier may be null (maybe handling it with a simple return t.identifier('Object'); in this case): do you have more info about the TSImportType?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know when the qualifier can be null, I just followed the TypeScript declaration for TSImportType

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be when the dynamic import not found

@tada5hi
Copy link
Copy Markdown

tada5hi commented Feb 17, 2023

what is missing here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants