feat: add E2E smoke tests, CORS for dev, and admin layout fixes#3
Open
leno23 wants to merge 1 commit into
Open
feat: add E2E smoke tests, CORS for dev, and admin layout fixes#3leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
- Add CORS middleware (non-production) for browser admin console - Fix admin shell full-height layout and loading state styling - Add Playwright API/UI smoke tests with npm scripts - Update gateway default port to 8081 in .env.example
|
Analysis CompleteGenerated ECC bundle from 1 commits | Confidence: 55% View Pull Request #4Repository Profile
Changed Files (15)
Top hotspots
Top directories
Analysis Depth Readiness (commit-history, 21%)ECC Tools uses this to decide whether recommendations should stay at commit-history/setup guidance or expand into CI, security, harness, reference-set, AI-routing, and team backlog work.
Reference Set Readiness (0/7, 0%)
Likely Future Issues (3)
Suggested Follow-up Work (3)
Copy-ready bodies test: add auth coverage for backend/internal/middleware/cors.go ## Summary
- Add auth, session, or permission regression coverage for the recently changed security-sensitive surface.
## Why
- Backfill auth or permission regression coverage before another access-control change lands on the touched surface.
## Touched paths
- `backend/internal/middleware/cors.go`
## Validation
- Add or extend integration / e2e coverage for the changed auth, session, middleware, or permission surface.
- Exercise allowed and denied flows, invalid or expired credentials, or equivalent access-control boundary cases.security: add scanner evidence for backend/internal/middleware/cors.go ## Summary
- Add security scanner or code-scanning evidence for the recently changed security-sensitive surface.
## Why
- Backfill explicit scanner or code-scanning evidence before another security-sensitive change lands on the touched surface.
## Touched paths
- `backend/internal/middleware/cors.go`
## Validation
- Run or add the relevant security scanner, code scanning, secret scanning, or dependency/security review check for the touched surface.
- Attach the scanner output, SARIF/code-scanning result, or focused security regression test to the follow-up PR.
- Confirm the changed auth, billing, webhook, secret-handling, agent, or CI surface has an explicit pass/fail gate.ci: add failure-mode evidence for frontend/playwright.config.ts ## Summary
- Add CI failure-mode evidence for the recently changed workflow or test-runner surface.
## Why
- Backfill CI failure-mode evidence before another workflow or test-runner change lands on the touched surface.
## Touched paths
- `frontend/playwright.config.ts`
## Validation
- Add or update a CI failure fixture, captured failing log, troubleshooting note, workflow dry-run evidence, or regression test for the changed CI/test-runner behavior.
- Run the affected workflow or test-runner entrypoint locally or in CI and record pass/fail evidence.Generated Instincts (14)
After merging, import with: Files
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1f8368fe9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,35 @@ | |||
| import { defineConfig, devices } from "@playwright/test"; | |||
|
|
|||
| const gatewayBase = process.env.GATEWAY_BASE_URL ?? "http://127.0.0.1:8081"; | |||
There was a problem hiding this comment.
Set the default GATEWAY_BASE_URL to match the backend’s default listener (HTTP_ADDR is :8080 in backend/internal/config/config.go), otherwise npm run test:e2e fails in the normal local setup when no override is provided. With the current default of http://127.0.0.1:8081, every API smoke request targets the wrong port unless users remember to reconfigure either the backend or env vars first.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.env.exampleand ignore Playwright artifactsTest plan
http://127.0.0.1:8081npm run devinfrontend/npm run test:e2eand verify API + UI smoke tests passMade with Cursor