Skip to content

Don't show pagination when loading#5747

Merged
MisRob merged 1 commit intolearningequality:unstablefrom
MisRob:pagination-loading
Mar 9, 2026
Merged

Don't show pagination when loading#5747
MisRob merged 1 commit intolearningequality:unstablefrom
MisRob:pagination-loading

Conversation

@MisRob
Copy link
Member

@MisRob MisRob commented Mar 9, 2026

Summary

A follow-up to #5696.

On unstable server with more cards than on localhost and pagination visible, I observed

  • Lack of space between cards and pagination
  • Pagination visible when loading

This should fix it.

@MisRob
Copy link
Member Author

MisRob commented Mar 9, 2026

@akolson I think it will be best to preview on production data after we merge to unstable, so for now just code review should do :)

Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @MisRob

@MisRob MisRob merged commit 59a13aa into learningequality:unstable Mar 9, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants