Show version history in the channel publish side panel by AllanOXDi · Pull Request #5721 · learningequality/studio

AllanOXDi · 2026-02-27T17:45:50Z

Summary

This PR adds a new hannelVersionHistory component to abstract all the channel version history displaying logic.
It uses the ChannelVersion resource to fetch channel versions in the frontend and rendered it on the PublishSidePanel component.
closes #5463

Screen.Recording.2026-03-05.at.23.17.55.mov

References

#5463

Reviewer guidance

Edit a channel and publish it with a few versions
Open a channel in the publish side panel
Click "See all versions" to expand the version history
Verify that versions load and display correctly with their descriptions

AI usage

I used Codex for Code review and refinement,styling improvements

rtibblesbot

New feature adds channel version history to the publish side panel via a ChannelVersionHistory component and useChannelVersionHistory composable with paginated fetching.

CI passing. No screenshots included — this PR adds a new UI component.

suggestion: Hardcoded colors in ChannelVersionHistory.vue — see inline comment
suggestion: Missing dedicated tests for ChannelVersionHistory and useChannelVersionHistory — see inline comment
suggestion: PR description is empty (template placeholders only) and no screenshots are included for a UI change
praise: Clean composable design — see inline comment

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Reviewed the pull request diff checking for:

Correctness: bugs, edge cases, undocumented behavior, resource leaks, hardcoded values
Design: unnecessary complexity, naming, readability, comment accuracy, redundant state
Architecture: duplicated concerns, minimal interfaces, composition over inheritance
Testing: behavior-based assertions, mocks only at hard boundaries, accurate coverage
Completeness: missing dependencies, unupdated usages, i18n, accessibility, security
Principles: DRY (same reason to change), SRP, Rule of Three (no premature abstraction)
Checked CI status and linked issue acceptance criteria
For UI changes: inspected screenshots for layout, visual completeness, and consistency

...uration/contentcuration/frontend/channelEdit/components/sidePanels/ChannelVersionHistory.vue

rtibblesbot · 2026-03-04T20:15:52Z

contentcuration/contentcuration/frontend/shared/composables/useChannelVersionHistory.js

+ *   fetchMore: () => Promise<void>,
+ * }}
+ */
+export function useChannelVersionHistory() {


praise: Clean separation of concerns. The composable encapsulates pagination state, loading states, and error handling well. The reset() function and guard clauses in fetchMore() are good defensive design.

...ontentcuration/frontend/channelEdit/components/sidePanels/__tests__/PublishSidePanel.spec.js

rtibblesbot · 2026-03-04T20:15:52Z

...uration/contentcuration/frontend/channelEdit/components/sidePanels/ChannelVersionHistory.vue

+            </div>
+            <div class="description-body">
+              {{ version.version_notes }}
+            </div>


nitpick: version.version_notes is rendered safely via text interpolation ({{ }}), which is good. Just noting that if notes can be long, you may want to consider truncation or overflow-wrap: break-word on .description-body to handle edge cases with very long unbroken strings.

rtibblesbot

Channel version history feature with clean composable + component separation, comprehensive tests, and proper i18n. CI passing.

2 prior finding(s) resolved.

suggestion: Hardcoded English aria-label — see inline comment
suggestion: hasMore logic inconsistency between initial fetch and pagination — see inline comment
suggestion (prior, unaddressed): PR description is still empty (template placeholders only) and no screenshots for a UI change
praise: Thorough test coverage — see inline comment

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Compared the current PR state against findings from a prior review:

Retrieved prior bot reviews deterministically via the GitHub API
Classified each prior finding as RESOLVED, UNADDRESSED, ACKNOWLEDGED, or CONTESTED
Only raised NEW findings for newly introduced code
Reviewed the pull request diff checking for correctness, design, architecture, testing, completeness, and adherence to DRY/SRP principles
Checked CI status and linked issue acceptance criteria

...uration/contentcuration/frontend/channelEdit/components/sidePanels/ChannelVersionHistory.vue

contentcuration/contentcuration/frontend/shared/composables/useChannelVersionHistory.js

...ation/contentcuration/frontend/shared/composables/__tests__/useChannelVersionHistory.spec.js

rtibblesbot

Channel version history feature looks solid. Clean composable/component separation, consistent pagination logic, comprehensive tests, and proper i18n throughout.

CI passing. Targets unstable (default branch) — new strings are appropriate.

4 prior finding(s) resolved.

suggestion (prior, unaddressed): PR description is still empty (template placeholders only) and no screenshots for a UI change — see inline comment

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Compared the current PR state against findings from a prior review:

Retrieved prior bot reviews deterministically via the GitHub API
Classified each prior finding as RESOLVED, UNADDRESSED, ACKNOWLEDGED, or CONTESTED
Only raised NEW findings for newly introduced code
Reviewed the pull request diff checking for correctness, design, architecture, testing, completeness, and adherence to DRY/SRP principles
Checked CI status and linked issue acceptance criteria

...uration/contentcuration/frontend/channelEdit/components/sidePanels/ChannelVersionHistory.vue

AlexVelezLl

Thanks a lot @AllanOXDi! Great work! I have just made a couple of small changes, one because I had incorrectly defined the ChannelVersionViewset with a pageNumber pagination instead of cursor pagination, and also just aligned the styles a little bit. Will wait until the checks pass, and will proceed to merge. Thanks!

rtibblesbot

Channel version history feature is solid — clean composable/component separation, proper i18n, cursor-based pagination, theme-aware styling, and comprehensive tests.

CI passing. Targets unstable (default branch) — new i18n strings are appropriate.

5 prior finding(s) resolved.

nitpick: Stale JSDoc comment — see inline comment

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Compared the current PR state against findings from a prior review:

Retrieved prior bot reviews deterministically via the GitHub API
Classified each prior finding as RESOLVED, UNADDRESSED, ACKNOWLEDGED, or CONTESTED
Only raised NEW findings for newly introduced code
Reviewed the pull request diff checking for correctness, design, architecture, testing, completeness, and adherence to DRY/SRP principles
Checked CI status and linked issue acceptance criteria

rtibblesbot · 2026-03-06T14:52:21Z

...uration/contentcuration/frontend/channelEdit/components/sidePanels/ChannelVersionHistory.vue

+   * Displays channel version history with pagination
+   *
+   * Shows a collapsible list of channel versions with their descriptions.
+   * Versions are fetched on-demand when expanded and paginated with 10 versions per page.


nitpick: JSDoc says "10 versions per page" but VERSIONS_PER_PAGE is 5.

rtibblesbot

Channel version history feature is clean and well-tested. Composable/component separation is solid, cursor-based pagination works correctly, i18n throughout, and theme-aware styling.

CI passing. Targets unstable (default branch) — new i18n strings are appropriate.

5 prior finding(s) resolved.

nitpick (prior, unaddressed): Stale JSDoc comment — see inline comment

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Compared the current PR state against findings from a prior review:

Retrieved prior bot reviews deterministically via the GitHub API
Classified each prior finding as RESOLVED, UNADDRESSED, ACKNOWLEDGED, or CONTESTED
Only raised NEW findings for newly introduced code
Reviewed the pull request diff checking for correctness, design, architecture, testing, completeness, and adherence to DRY/SRP principles
Checked CI status and linked issue acceptance criteria

rtibblesbot · 2026-03-06T15:09:49Z

...uration/contentcuration/frontend/channelEdit/components/sidePanels/ChannelVersionHistory.vue

+   * Displays channel version history with pagination
+   *
+   * Shows a collapsible list of channel versions with their descriptions.
+   * Versions are fetched on-demand when expanded and paginated with 5 versions per page.


nitpick (prior, unaddressed): JSDoc says "10 versions per page" but VERSIONS_PER_PAGE is 5.

Suggested change

* Versions are fetched on-demand when expanded and paginated with 5 versions per page.

* Shows a collapsible list of channel versions with their descriptions.

* Versions are fetched on-demand when expanded and paginated with 5 versions per page.

It is now addressed!

rtibblesbot

Channel version history feature is clean and well-structured. CI still in progress (Python tests running).

5 prior finding(s) resolved.

nitpick (prior, unaddressed): Stale JSDoc comment — see inline comment

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Compared the current PR state against findings from a prior review:

Retrieved prior bot reviews deterministically via the GitHub API
Classified each prior finding as RESOLVED, UNADDRESSED, ACKNOWLEDGED, or CONTESTED
Only raised NEW findings for newly introduced code
Reviewed the pull request diff checking for correctness, design, architecture, testing, completeness, and adherence to DRY/SRP principles
Checked CI status and linked issue acceptance criteria

add channel version history to publish side panel

e033d2f

AllanOXDi requested a review from rtibblesbot March 4, 2026 20:12

rtibblesbot reviewed Mar 4, 2026

View reviewed changes

Fix hasMore logic to require a full page before showing Show more.

f19d93c

AllanOXDi closed this Mar 5, 2026

AllanOXDi reopened this Mar 5, 2026

rtibblesbot reviewed Mar 5, 2026

View reviewed changes

fix hasMore logic

568ae8c

AllanOXDi requested review from AlexVelezLl and akolson March 5, 2026 20:59

rtibblesbot reviewed Mar 5, 2026

View reviewed changes

...uration/contentcuration/frontend/channelEdit/components/sidePanels/ChannelVersionHistory.vue Show resolved Hide resolved

AllanOXDi marked this pull request as ready for review March 5, 2026 21:03

Change ChannelVersion viewset to use cursor based pagination

f8eac9e

AlexVelezLl force-pushed the Ch-version branch from 8db0e6f to a0f4c6f Compare March 6, 2026 14:38

AlexVelezLl approved these changes Mar 6, 2026

View reviewed changes

rtibblesbot reviewed Mar 6, 2026

View reviewed changes

Update styles

83219f5

AlexVelezLl force-pushed the Ch-version branch from a0f4c6f to 83219f5 Compare March 6, 2026 15:07

rtibblesbot reviewed Mar 6, 2026

View reviewed changes

AlexVelezLl merged commit 68f6102 into learningequality:unstable Mar 6, 2026
13 checks passed

	* Versions are fetched on-demand when expanded and paginated with 5 versions per page.
	* Shows a collapsible list of channel versions with their descriptions.
	* Versions are fetched on-demand when expanded and paginated with 5 versions per page.

Conversation

AllanOXDi commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

References

Reviewer guidance

AI usage

Uh oh!

rtibblesbot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rtibblesbot Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rtibblesbot Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

rtibblesbot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rtibblesbot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexVelezLl left a comment

Choose a reason for hiding this comment

Uh oh!

rtibblesbot left a comment

Choose a reason for hiding this comment

Uh oh!

rtibblesbot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

rtibblesbot left a comment

Choose a reason for hiding this comment

Uh oh!

rtibblesbot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

AlexVelezLl Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

rtibblesbot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AllanOXDi commented Feb 27, 2026 •

edited

Loading