improve error handling for deleted users in course assignment#14210
Conversation
Build Artifacts
|
|
my apologies, @AllanOXDi, I was reading this too quickly this morning and didn't realize that you had split the work into two distinct PRs and targeted just the courses one here. That was really thoughtful, and I'm sorry that I missed it! 0.19 is appropriate for this. I've updated accordingly. sorry for the confusion. QA note: Allan and I discussed strings and for now they are "working" strings to convey the general behavior. this will still go through UX writing review for 0.20 :) |
AlexVelezLl
left a comment
There was a problem hiding this comment.
Given that catching backend error messages will require some more design and decisions, we have agreed to keep this PR as is, and try to standardize our API error handling in a follow-up PR. So, this should be ready for QA review!
pcenov
left a comment
There was a problem hiding this comment.
Thanks @AllanOXDi - I confirm that attempting to assign a course to a deleted user results in seeing the following message: There was a problem saving this course. One or more selected users no longer exist in this facility. Please refresh the page and try again.
A note that we are still showing the generic error message Sorry! Something went wrong, please try again. if I try to assign the course to a deleted class or a group but my understanding is that this is good enough for the time being.
228ce10
into
learningequality:release-v0.19.x
Summary
Please see #14209
Before
deleted.mp4
After
References
#14155
Reviewer guidance
See #14209