Skip to content

improve error handling for deleted users in course assignment#14210

Merged
AlexVelezLl merged 1 commit intolearningequality:release-v0.19.xfrom
AllanOXDi:fix-deleted-users-courses
Mar 10, 2026
Merged

improve error handling for deleted users in course assignment#14210
AlexVelezLl merged 1 commit intolearningequality:release-v0.19.xfrom
AllanOXDi:fix-deleted-users-courses

Conversation

@AllanOXDi
Copy link
Copy Markdown
Member

Summary

Please see #14209

Before

deleted.mp4

After

Screenshot 2026-02-19 at 16 40 00

References

#14155

Reviewer guidance

See #14209

@github-actions github-actions Bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small labels Feb 19, 2026
@marcellamaki
Copy link
Copy Markdown
Member

marcellamaki commented Feb 23, 2026

hi @AllanOXDi -- can you please retarget this to develop since it will go there due to the new strings? thank you 🙏

my apologies, @AllanOXDi, I was reading this too quickly this morning and didn't realize that you had split the work into two distinct PRs and targeted just the courses one here. That was really thoughtful, and I'm sorry that I missed it! 0.19 is appropriate for this. I've updated accordingly. sorry for the confusion.

QA note: Allan and I discussed strings and for now they are "working" strings to convey the general behavior. this will still go through UX writing review for 0.20 :)

@AllanOXDi AllanOXDi changed the base branch from release-v0.19.x to develop February 23, 2026 15:28
@marcellamaki marcellamaki changed the base branch from develop to release-v0.19.x February 23, 2026 20:27
Copy link
Copy Markdown
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that catching backend error messages will require some more design and decisions, we have agreed to keep this PR as is, and try to standardize our API error handling in a follow-up PR. So, this should be ready for QA review!

@pcenov pcenov self-requested a review March 6, 2026 14:58
Copy link
Copy Markdown
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AllanOXDi - I confirm that attempting to assign a course to a deleted user results in seeing the following message: There was a problem saving this course. One or more selected users no longer exist in this facility. Please refresh the page and try again.
A note that we are still showing the generic error message Sorry! Something went wrong, please try again. if I try to assign the course to a deleted class or a group but my understanding is that this is good enough for the time being.

@AlexVelezLl AlexVelezLl merged commit 228ce10 into learningequality:release-v0.19.x Mar 10, 2026
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants