Skip to content

merge nanoda into sonanoda, fixing bug#41

Merged
nomeata merged 2 commits into
leanprover:masterfrom
datokrat:rebase-sonanoda
Apr 28, 2026
Merged

merge nanoda into sonanoda, fixing bug#41
nomeata merged 2 commits into
leanprover:masterfrom
datokrat:rebase-sonanoda

Conversation

@datokrat
Copy link
Copy Markdown
Contributor

This PR bumps sonanoda, which was rebased on top of nanoda's latest version. The latest version of nanoda fixed a correctness bug.

@nomeata
Copy link
Copy Markdown
Collaborator

nomeata commented Apr 28, 2026

Looks good, undraft and merge?

(And rebasing branches that have been published is bad style, that’s what normal merges are for :-))

@datokrat
Copy link
Copy Markdown
Contributor Author

datokrat commented Apr 28, 2026

Oh, you're right. I forgot that sonanoda was already in the stage where a fork exists... I'll undo the rebase as my last sin, then continue virtuously.

@datokrat datokrat changed the title rebase sonanoda merge nanoda into sonanoda, fixing bug Apr 28, 2026
@datokrat datokrat marked this pull request as ready for review April 28, 2026 12:01
@nomeata nomeata merged commit 9b8e20e into leanprover:master Apr 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants