feat: add lint-args configuration input#149
Open
GZGavinZhao wants to merge 1 commit intoleanprover:mainfrom
Open
feat: add lint-args configuration input#149GZGavinZhao wants to merge 1 commit intoleanprover:mainfrom
GZGavinZhao wants to merge 1 commit intoleanprover:mainfrom
Conversation
GZGavinZhao
force-pushed
the
gzgz/jj-vvunnulqpvnw
branch
4 times, most recently
from
11b09de to
5e9ff01
Compare
GZGavinZhao
changed the title
GZGavinZhao
force-pushed
the
gzgz/jj-vvunnulqpvnw
branch
from
5e9ff01 to
3448a7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150.
The implementation is the exact same as
test-argsin #135.I do have one implementation concern. Right now the
lint-argsis naively appended tolake lint, but almost all the arguments I want to pass are to the linter driver, which is done throughlake lint -- arg1 arg2.It doesn't seem like
lake linttakes any flags or arguments anyway judging fromlake lint --help. Therefore, would it be reasonable to always add--betweenlake lintand$LINT_ARGSso I don't have to writelint-args: "-- arg1 arg2"and can just writelint-args: "arg1 arg2"?