Add frequent node logging: attestations, blocks, justified/finalized, peers#431
Closed
ch4r10t33r wants to merge 10 commits intoleanEthereum:mainfrom
Closed
Add frequent node logging: attestations, blocks, justified/finalized, peers#431ch4r10t33r wants to merge 10 commits intoleanEthereum:mainfrom
ch4r10t33r wants to merge 10 commits intoleanEthereum:mainfrom
Conversation
Introduces a new --is-aggregator command-line parameter that enables aggregator mode for consensus nodes. When enabled, the node performs attestation aggregation operations and advertises this capability in its ENR. Changes: - Add is_aggregator field to NodeConfig with default value False - Add IS_AGGREGATOR ENR key constant for peer discovery - Add is_aggregator property to ENR class for reading aggregator flag - Add is_aggregator field to NetworkService for ENR advertisement - Add --is-aggregator CLI argument with help text - Thread flag through initialization paths (genesis and checkpoint sync) - Add logging when aggregator mode is enabled Usage: python -m lean_spec --genesis config.yaml --is-aggregator The flag defaults to False, maintaining backward compatibility with existing deployments. When True, the node's ENR will include the is_aggregator key, allowing peers to discover aggregator nodes.
- Build image for linux/amd64 and linux/arm64 on every PR and push to main - Publish ghcr.io/leanethereum/leanspec-node:latest only on merge to main
Avoid transient failures when uv fetches python-build-standalone (HTTP/2 stream errors). Use Actions tool-cache Python instead.
… peers - Sync: log block received/processed with peer and slot; log attestation and aggregated attestation with peer, slot, validator and validation/signature result - Sync: optional peer_id on on_gossip_attestation and on_gossip_aggregated_attestation - Network: pass peer_id from gossip events to sync handlers - Node: periodic (10s) log of justified slot, finalized slot, and connected peers count
Collaborator
Author
|
Superseded by #432 (same changes, branch contains only the logging commits). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds observability logging to the leanSpec node:
Sync service accepts optional
peer_idonon_gossip_attestationandon_gossip_aggregated_attestation; network service passes peer_id from gossip events so logs show the propagating peer.