perf: replace heap allocations with stack arrays in logup inner loops#161
Merged
TomWambsgans merged 1 commit intoleanEthereum:mainfrom Mar 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154.
Replaces two
Vecheap allocations with stack-allocated fixed-size arrays in the hot inner loops ofprove_generic_logup:Bytecode lookup denominator (line 119):
Vec::with_capacity(1 + N_INSTRUCTION_COLUMNS)→[F::ZERO; N_INSTRUCTION_COLUMNS + 1]— matching the existing pattern at lines 88-90.Bus denominator (lines 147-153):
.collect::<Vec<_>>()→[F::ZERO; N_INSTRUCTION_COLUMNS]with explicit length slice&bus_data[..bus.data.len()]. All bus data lengths are ≤ 4 (verified across all table implementations), well within theN_INSTRUCTION_COLUMNS = 12bound.Bytecode columns collection (line 111):
.collect::<Vec<_>>()→ slice reference, avoiding an unnecessaryVecallocation.These allocations occur inside
par_iter_mut().for_each()closures, meaning they execute once per row of the trace — potentially millions of times. Stack arrays eliminate per-iteration allocator pressure and improve cache locality.