Open
Conversation
- Now simple (w/ dot) and nested instances (w/o dot) in operands are consistently stored as relative instances. - The interpreter handles path resolution.
Release: staging → main
Collaborator
Author
|
@JayHuLBL Ready for your review. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses #428, as well as the sub-issues checked at #428.
This comes on top of the already open PR Ag/495 new schema #496 and Ag/485 fix config values #486
The current PR introduces significant changes to the parsing of class modifications, addressing Fix parsing logic for class modifications #497, in addition to the newly added functionality (support for composite record bindings).
Testing
New functionality
A new test package with record bindings in various constructs is included (server/tests/static-data/TestRecord.mo) and used for testing both the parser and the interpreter.
The HP plant template JSON file is also included for further testing the interpreter on a real-world complex AST (client/tests/data/templates.json.gz).
Existing functionality
End-to-end tests have also been performed by creating the SOO document with the following system options.
AHU
Cooling-only box
✅ The feature branch produces the same document as the main branch.