Relocate /assets/images/partner to static/partners by asgharali97 · Pull Request #7268 · layer5io/layer5

asgharali97 · 2025-12-19T22:52:02Z

Description

This PR fixes #7256 by relocating assets/images/partners to static/partners and updating all references to use absolute static paths.

Dynamic image imports were replaced with string-based "/partners/..." paths to align with Gatsby’s static asset handling.
This PR fixes #7256

Notes for Reviewers

No functional changes beyond asset relocation and reference updates.
No imports from static/ are used; assets are referenced via absolute paths.

Signed commits

Yes, I signed my commits.

saurabhraghuvanshii · 2025-12-20T18:19:06Z

@asgharali97 build faling please fix that

asgharali97 · 2025-12-21T20:55:02Z

Hi @saurabhraghuvanshii,
Thanks for telling build failure

I’ve reviewed the CI logs and the error appears to originate from src/templates/program-multiple.js where a non-null graphQL variable ($program) is receiving a null value during page generation (/programs/null.html)

This seems related to existing MDX content under src/collections/programs/ (e.g. hacktoberfest-2023) rather than the partner logo relocation in this PR. I didn’t modify any program templates, collections, or GraphQL logic here.

Please let me know if you’d like me to help investigate or address this separately.

kishore08-07 · 2025-12-22T03:54:04Z

@asgharali97
Thank you for your contribution!
Let's discuss this during the website call today at 6:30 PM IST | 8 AM CT
Add it as an agenda item to the meeting minutes, if you would :)

asgharali97 · 2025-12-22T13:01:54Z

Hi @kishore08-07, Thank you for inviting. I would love to join

CodexRaunak · 2026-02-23T00:57:49Z

@asgharali97 merge conflicts to address.

saurabhraghuvanshii · 2026-04-23T08:58:34Z

@asgharali97 can you resolve merge conflicts?

asgharali97 · 2026-04-24T12:41:42Z

Hi @saurabhraghuvanshii ,I noticed there’s another PR (#7439) addressing the same issue and it seems to have passing checks.

Should I still proceed with updating this PR and resolving conflicts, or has that PR effectively replaced this one?

saurabhraghuvanshii · 2026-04-24T15:30:08Z

@asgharali97 yeah also address the suggestion move images to static/images/patners

saurabhraghuvanshii · 2026-04-27T12:28:45Z

@asgharali97 are you going to update this?

asgharali97 · 2026-04-27T18:14:04Z

Hi @saurabhraghuvanshii, Yes, I’m working on updating it. I’ve reset to the latest upstream and am reapplying the changes to align with the current structure. I’ll push an update shortly.

Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Asghar Ali <asgharalifs48@gmail.com>

Signed-off-by: Asghar Ali <asgharalifs48@gmail.com>

github-actions · 2026-04-27T21:46:47Z

🚀 Preview deployment: https://layer5.io/pr-preview/pr-7268/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

asgharali97 · 2026-04-27T21:54:52Z

Hi @saurabhraghuvanshii, I’ve addressed the issues and updated the PR. It is now ready for review.

Please let me know if any further changes are needed. Thanks!

rishiraj38 · 2026-05-04T15:28:44Z

      id={partner.name}
      loading="lazy"
-      src={imageSrc}
+      src={partner.imageSrc}


Please Update this to partner.imageLink

thechillbasu · 2026-05-04T15:11:55Z

 author: Lee Calcote
-thumbnail: "../../../../assets/images/partners/intel-grey.webp"
-darkthumbnail: "../../../../assets/images/partners/intel_white.webp"
+


Why add an extra line? There are several extra lines added throughout the files. I am not sure if its required.

@thechillbasu Thanks for pointing that out! I’ve cleaned up the unnecessary extra lines and kept the changes minimal. Please take another look.

Thanks! Actually it wasn't that big of an issue but still, sometimes keeping the code structure more uniform is better. And avoiding unnecessary formatting helps the reviewer focus on the actual necessary changes. Most of the formatting was ok, some were actually good but a few were unnecessary but I guess those were unintentional. Anyways, good work. Thanks for your contribution!

thechillbasu · 2026-05-04T15:38:19Z

      id={partner.name}
      loading="lazy"
-      src={imageSrc}
+      src={partner.imageSrc}


Shouldn't this be src={partner.imageLink} since the partners-home-data.js uses the key imageLink?

rishiraj38 · 2026-05-04T15:57:51Z

 author: Lee Calcote
-thumbnail: "../../../../assets/images/partners/intel-grey.svg"
-darkthumbnail: "../../../../assets/images/partners/intel_white.svg"
+thumbnail: "/images/partners/intel-grey.svg"


Using an absolute path here might break the blog thumbnail. Because our schema explicitly uses @fileByRelativePath for thumbnails(https://github.com/layer5io/layer5/blob/master/gatsby-node.js#L1213), Gatsby's GraphQL needs this to be a relative path so it can process the image as a File node.

@saurabhraghuvanshii ^^ I’m not sure about this because I can’t build the blog locally either.

@rishiraj38 , I think you're correct here.

@asgharali97 please fix here

thechillbasu · 2026-05-04T16:05:23Z

+    imageRoute:
+      "/company/news/layer5-and-hashicorp-launch-service-mesh-partnership",


I think it would be better to add the path in the same line as the key.

Signed-off-by: Asghar Ali <asgharalifs48@gmail.com> fix: correct image source property in LazyPartnerImage component

rishiraj38 · 2026-05-04T17:03:08Z

 author: Lee Calcote
-thumbnail: "../../../../assets/images/partners/intel-grey.svg"
-darkthumbnail: "../../../../assets/images/partners/intel_white.svg"
+thumbnail: "/images/partners/intel-grey.svg"


@asgharali97 please fix here

rishiraj38 · 2026-05-04T17:03:21Z

 author: Lee Calcote
-thumbnail: "../../../../assets/images/partners/intel-grey.webp"
-darkthumbnail: "../../../../assets/images/partners/intel_white.webp"
+thumbnail: "/images/partners/intel-grey.webp"


rishiraj38 · 2026-05-04T17:03:28Z

-thumbnail: "../../../../assets/images/partners/intel-grey.webp"
-darkthumbnail: "../../../../assets/images/partners/intel_white.webp"
+thumbnail: "/images/partners/intel-grey.webp"
+darkthumbnail: "/images/partners/intel_white.webp"


rishiraj38 · 2026-05-04T17:03:35Z

-thumbnail: "../../../../assets/images/partners/intel-grey.svg"
-darkthumbnail: "../../../../assets/images/partners/intel_white.svg"
+thumbnail: "/images/partners/intel-grey.svg"
+darkthumbnail: "/images/partners/intel_white.svg"


Signed-off-by: Asghar Ali <asgharalifs48@gmail.com>

Sbragul26 · 2026-05-05T04:19:50Z

A few things still need fixing — the old /assets/images/partners folder is still there. Since everything has been moved to /static/images/partners , could you please remove the old folder as well?

thechillbasu · 2026-05-05T08:36:18Z

A few things still need fixing — the old /assets/images/partners folder is still there. Since everything has been moved to /static/images/partners , could you please remove the old folder as well?

@Sbragul26 I think we can't do that because, as discussed, the blog posts, i.e., the mdx files still point to that folder so that they can be processed through the Gatsby Image Pipeline.

asgharali97 · 2026-05-05T11:49:37Z

@Sbragul26 Thanks for raising this! Based on the earlier discussion around Gatsby’s image processing, the .mdx files still rely on the assets/images/partners directory for thumbnails via the GraphQL pipeline.

So I’ve kept that folder intact while moving runtime image usage to static/images/partners. Please let me know if you’d prefer a different approach.

github-actions Bot added area/blog New posts or new blog functionality area/events labels Dec 19, 2025

asgharali97 force-pushed the chore/relocate-partner-logos branch 2 times, most recently from 97975de to 01661a8 Compare December 20, 2025 13:28

asgharali97 force-pushed the chore/relocate-partner-logos branch from 6577e4a to 1878ab6 Compare April 27, 2026 19:43

asgharali97 and others added 3 commits April 28, 2026 01:48

relocate partner images to static/images/partners and update references

da49613

Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Asghar Ali <asgharalifs48@gmail.com>

refactor: update partner logo imports to use constants

18cd2d6

Signed-off-by: Asghar Ali <asgharalifs48@gmail.com>

fix: add lazy loading to Docker logo image

6f2f9f9

Signed-off-by: Asghar Ali <asgharalifs48@gmail.com>

asgharali97 force-pushed the chore/relocate-partner-logos branch from c718230 to 6f2f9f9 Compare April 27, 2026 20:49

refactor: export partner logo constants for consistency

2141802

Signed-off-by: Asghar Ali <asgharalifs48@gmail.com>

rishiraj38 suggested changes May 4, 2026

View reviewed changes

thechillbasu suggested changes May 4, 2026

View reviewed changes

rishiraj38 suggested changes May 4, 2026

View reviewed changes

thechillbasu reviewed May 4, 2026

View reviewed changes

fix: correct image source property in LazyPartnerImage component

a58775f

Signed-off-by: Asghar Ali <asgharalifs48@gmail.com> fix: correct image source property in LazyPartnerImage component

asgharali97 force-pushed the chore/relocate-partner-logos branch from 18df128 to a58775f Compare May 4, 2026 16:22

rishiraj38 suggested changes May 4, 2026

View reviewed changes

refactor: update partner logo paths to use relative imports

2cd8e28

Signed-off-by: Asghar Ali <asgharalifs48@gmail.com>

		imageRoute:
		"/company/news/layer5-and-hashicorp-launch-service-mesh-partnership",

Conversation

asgharali97 commented Dec 19, 2025

Uh oh!

saurabhraghuvanshii commented Dec 20, 2025

Uh oh!

asgharali97 commented Dec 21, 2025

Uh oh!

kishore08-07 commented Dec 22, 2025

Uh oh!

asgharali97 commented Dec 22, 2025

Uh oh!

CodexRaunak commented Feb 23, 2026

Uh oh!

saurabhraghuvanshii commented Apr 23, 2026

Uh oh!

asgharali97 commented Apr 24, 2026

Uh oh!

saurabhraghuvanshii commented Apr 24, 2026

Uh oh!

saurabhraghuvanshii commented Apr 27, 2026

Uh oh!

asgharali97 commented Apr 27, 2026

Uh oh!

github-actions Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asgharali97 commented Apr 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thechillbasu May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thechillbasu May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sbragul26 commented May 5, 2026

Uh oh!

thechillbasu commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asgharali97 commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions Bot commented Apr 27, 2026 •

edited

Loading

thechillbasu May 4, 2026 •

edited

Loading

thechillbasu May 4, 2026 •

edited

Loading

thechillbasu commented May 5, 2026 •

edited

Loading