fix: constrain working section height#44
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9a3e9d06e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| )} | ||
| {canExpand && (item.isRunning || open) ? ( | ||
| <div className="grid min-w-0 gap-1"> | ||
| <div className={workContentClassName}> |
There was a problem hiding this comment.
Constraining the work list to overflow-y-auto without any scroll-position management means a running request can stop showing new activity once the list exceeds max-h: the container stays at its current scrollTop (initially the top), while new rows are appended below. In this component, item.activities is rendered in chronological order, so the newest status updates become hidden during long runs unless the user manually scrolls, which regresses live monitoring behavior for active tasks.
Useful? React with 👍 / 👎.
| } from "./types/chatComponents"; | ||
|
|
||
| const workContentClassName = | ||
| "grid min-w-0 max-h-[min(22rem,45vh)] gap-1 overflow-y-auto overscroll-contain pr-2 [-webkit-mask-image:linear-gradient(to_bottom,transparent,black_12px,black_calc(100%-12px),transparent)] [mask-image:linear-gradient(to_bottom,transparent,black_12px,black_calc(100%-12px),transparent)]"; |
There was a problem hiding this comment.
The mask gradient uses calc(100%-12px) in both mask-image declarations, but CSS calc() requires spaces around binary -. Because that token is invalid, browsers drop the mask value, so the intended top/bottom fade cue will not render. This breaks the new affordance introduced by this change even when the list is overflowing.
Useful? React with 👍 / 👎.
1 participant
Summary
Limit the chat Working section height and make overflowing activity content scroll within the section.
Context
Resolves #36. Long working/activity histories could dominate the chat UI and push useful conversation content out of view.
Changes
min(22rem, 45vh).Testing
cargo check --manifest-path src-tauri/Cargo.tomlgit diff --checkNote: TypeScript build checks could not be run in this environment because
npxis not installed.Links