fix: use rao instead of tao in Balance.__floordiv__ for consistency#922
Open
Grizouforever wants to merge 5 commits intolatent-to:stagingfrom
Open
fix: use rao instead of tao in Balance.__floordiv__ for consistency#922Grizouforever wants to merge 5 commits intolatent-to:stagingfrom
Grizouforever wants to merge 5 commits intolatent-to:stagingfrom
Conversation
Release/9.19.0
Release/9.20.0
Release/9.20.1
Balance.__floordiv__ uses self.tao // other.tao while every other arithmetic operator (__add__, __sub__, __mul__, __truediv__, __rfloordiv__) consistently uses .rao. This inconsistency produces incorrect results when dividing two Balance objects. Change to self.rao // other.rao to match the pattern used by all other operators.
thewhaleking
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Balance.__floordiv__usesself.tao // other.tao(float values) while every other arithmetic operator consistently uses.rao(integer):__add__self.rao + other.rao__sub__self.rao - other.rao__mul__self.rao * other.rao__truediv__self.rao / other.rao__rfloordiv__other / self.rao__floordiv__self.tao // other.taoChanges
Change
self.tao // other.taotoself.rao // other.raoinbalances.pyline 214 to match the pattern used by all sibling operators.