Include application's command-line in logs#270
Draft
ueno wants to merge 1 commit into
Draft
Conversation
This embeds command line of the running application in the primary log as well as the crau-query output. To preserve backward compatibility, if the "command" field is missing in the primary log, an empty string will be assumed. Signed-off-by: Daiki Ueno <dueno@redhat.com>
neverpanic
reviewed
May 12, 2026
| }; | ||
|
|
||
| #define MAX_BUILD_ID_SIZE 64 | ||
| #define MAX_COMMAND_SIZE 64 |
Collaborator
There was a problem hiding this comment.
That feels very short, I expect we'll have many processes that use longer strings than that.
| context); | ||
| event->parent = parent; | ||
|
|
||
| err = bpf_get_current_comm (event->command, sizeof(event->command)); |
Collaborator
There was a problem hiding this comment.
Maybe bpf_get_cgroup_classid would also be useful to have in the logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This embeds command line of the running application in the primary log as well as the crau-query output. To preserve backward compatibility, if the "command" field is missing in the primary log, an empty string will be assumed.