fix: update to @vitejs/plugin-react v6 remove babel and add memoization#325
Closed
joshdonnell wants to merge 1 commit intolaravel:mainfrom
Closed
fix: update to @vitejs/plugin-react v6 remove babel and add memoization#325joshdonnell wants to merge 1 commit intolaravel:mainfrom
joshdonnell wants to merge 1 commit intolaravel:mainfrom
Conversation
|
@joshdonnell I am wondering why you choose to remove the react compiler instead of using the new way to include the react compiler. Removing automatic memoization will make this start kit worse in every way possible. The release notes clearly state how to keep the react compiler by using the rolldown plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
@vitejs/plugin-reactv6, Babel support is dropped, meaning the auto memoization we get from the Babel compiler is no longer included.This PR: