chore: remove marketplace script, refactor mirror script#593
Open
John Kennedy (jkennedyvz) wants to merge 2 commits intomainfrom
Open
chore: remove marketplace script, refactor mirror script#593John Kennedy (jkennedyvz) wants to merge 2 commits intomainfrom
John Kennedy (jkennedyvz) wants to merge 2 commits intomainfrom
Conversation
John Kennedy (jkennedyvz)
requested a review
from Romain Priour (romain-priour-lc)
John Kennedy (jkennedyvz)
requested a review
from Mukil Loganathan (langchain-infra)
Marketplace release tooling has been moved to the deployments repo (marketplace/aws/) alongside the existing Azure marketplace scripts. See: langchain-ai/deployments#25458 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
John Kennedy (jkennedyvz)
force-pushed
the
fix/aws-marketplace-helm-validation
branch
from
d7d0fbc to
130c50e
Compare
John Kennedy (jkennedyvz)
changed the title
John Kennedy (jkennedyvz)
changed the title
Contributor
There was a problem hiding this comment.
we still want this, we just odnt need the aws specific components
Remove the --dest-repo marketplace mode (moved to deployments repo) and read the image list directly from values.yaml instead of hardcoding DEFAULT_VERSION. This ensures the mirror script always stays in sync with whatever the chart actually packages. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
John Kennedy (jkennedyvz)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_marketplace_version.sh(moved to deployments repo)mirror_langsmith_images.shto:values.yamlinstead of hardcodingDEFAULT_VERSION— images always match the chart--dest-repomarketplace mode (AWS-specific, moved to deployments)--versionas optional override for LangChain images (infra image tags stay as-is)Addresses review feedback
Test plan
--dry-runcorrectly reads all 14 images from values.yaml--versionoverride applies only to langchain images, not postgres/redis/clickhousecreate_marketplace_version.shremoved