Conversation
…r in length than the argument being checked
✅ Coverage Report📊 View Full HTML Report (download artifact) Overall Coverage
Changed Files in This PR
PR Files Coverage: 75.94% (767/1010 lines) Generated by cargo-llvm-cov · Latest main coverage Last updated: 2026-03-12 19:59:30 UTC · Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve unknown-argument suggestion performance in
lambda-rs-argsby pruning candidates that cannot beat the current best Levenshtein distance based on character-length lower bounds.Related Issues
N/A
Changes
unknown_with_suggestionto skip Levenshtein calls whenabs(len(key) - len(arg)) >= best_distance.did you mean ...).Type of Change
Affected Crates
lambda-rslambda-rs-platformlambda-rs-argslambda-rs-loggingChecklist
cargo +nightly fmt --all)cargo clippy --workspace --all-targets -- -D warnings)cargo test --workspace)Testing
Commands run:
cargo test -p lambda-rs-argsManual verification steps (if applicable):
--porttvs--port) and verify suggestion output remains correct.Screenshots/Recordings
N/A
Platform Testing
Additional Notes
Asymptotics: worst-case remains
O(A * L^2)forAcandidate args andLstring length, but the prune reduces expensive Levenshtein evaluations fromO(A)toO(K)in common cases (K <= A) where many candidates are length-mismatched.