Added new staging/prod deployment workflow including database testing#244
Added new staging/prod deployment workflow including database testing#244
Conversation
neagualexa
left a comment
neagualexa
left a comment
There was a problem hiding this comment.
A few comments regarding the secrets passed on to the workflows in the other repo and some other small bits
.github/workflows/staging-deploy.yml
Outdated
| .venv/bin/pip install pytest | ||
| .venv/bin/pip install -r app/requirements.txt | ||
|
|
||
| # TODO: add linting / black / flake8 |
There was a problem hiding this comment.
is this still a valid todo? or is it old code from shimmy (as i remember linting check was removed at some point)
There was a problem hiding this comment.
Linting check was removed, and we can either remove it or enable it here, I don't have a preference.
There was a problem hiding this comment.
then leave it for now commented if they do not pass, just to keep the notice
There was a problem hiding this comment.
Enabled and flxed the errors
| build-context: "./app" | ||
| build-platforms: "aws" | ||
| environment: "staging" | ||
| lfs: false |
There was a problem hiding this comment.
why doesn't staging also have the run-tests : true?
There was a problem hiding this comment.
run-tests here, means databases tests. I will rename this.
Database tests is where we have a LambdaFunction call the data analysis database and call the staging deployment,
There was a problem hiding this comment.
Renamed to run-database-tests
3 participants
Problem:
Unable to test changes to compareExpressions on staging without also deploying to prod.
Fix:
Implement the new workflows we have been trying on different evaluation functions.