Feat: option to view biome name in Coordinates.kt (HUD elem)#264
Open
TwinkNet wants to merge 4 commits intolambda-client:1.21.11from
Open
Feat: option to view biome name in Coordinates.kt (HUD elem)#264TwinkNet wants to merge 4 commits intolambda-client:1.21.11from
TwinkNet wants to merge 4 commits intolambda-client:1.21.11from
Conversation
Author
|
With dim view enabled: |
IceTank
suggested changes
Mar 10, 2026
| } | ||
|
|
||
| private val showDimension by setting("Show Dimension Name", true) | ||
| private val showBiome by setting("Show Biome Name", true) // TwinkNet - Show biome |
Contributor
There was a problem hiding this comment.
This line comment is not necessary. This is not a paper server patch.
|
|
||
| val withDimension = | ||
| if (showDimension) "$text ${world.dimensionName}" | ||
| // TwinkNet start - show biome |
Contributor
There was a problem hiding this comment.
Same with these comments and all below
IceTank
reviewed
Mar 10, 2026
| } | ||
|
|
||
| // TwinkNet start - Show biome | ||
| fun beautifyBiome(biome: String): String { |
Contributor
There was a problem hiding this comment.
This function can be refactored to be more readable and in line with native kotlin methods.
fun beautifyBiome(biome: String): String = biome
.substringAfterLast(':')
.replace('_', ' ')
.split(' ')
.joinToString(" ") { it.replaceFirstChar(Char::uppercaseChar) }
Author
|
fixed yeah sorry i've never written kotlin before |
IceTank
reviewed
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements a new option for the Coordinates HUD module called "Show Biome Name" that will append a beautified biome name in your coordinates module.
Checklist Before Submitting
To ensure the quality and maintainability of your PR, confirm the following before submission: