Decompiler: avoid passing Sleigh IDs to BFD#3
Open
0xeb wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Why:
resolveArchitecture() already treats colon-containing targets as Sleigh language ids. However, buildLoader() passed the same string through LoadImageBfd to bfd_openr(), where it is interpreted as a BFD target name. Values such as AARCH64:LE:64:v8A:default are valid Ghidra language ids, not BFD target names.
BFD distinguishes a NULL/default target from a literal empty target string. Passing NULL lets bfd_check_format() probe the supported object formats.
Testing: