Skip to content

Update omniauth dependency to support 1.0 and 2.0 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wilson29thid wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update omniauth dependency to support 1.0 and 2.0 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e452ca
Update omniauth dependency to support 1.0 and 2.0
wilson29thid Jul 23, 2022
92ec18c
Use CGI.escape instead of the deprecated URI.escape
wilson29thid Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/omniauth/strategies/discourse/sso.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def base64_encoded_payload
end

def url_encoded_payload
URI.escape(base64_encoded_payload)
CGI.escape(base64_encoded_payload)
end

def hex_signature
Expand All @@ -83,4 +83,4 @@ def base64? data
end
end
end
end
end
2 changes: 1 addition & 1 deletion omniauth-discourse.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Gem::Specification.new do |gem|
gem.homepage = "https://github.com/lackstein/omniauth-discourse"
gem.license = "MIT"

gem.add_dependency "omniauth", "~> 1.0"
gem.add_dependency "omniauth", ">= 1.0", "< 3"
gem.add_development_dependency "bundler", "~> 1.9"

gem.executables = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
Expand Down