Conversation
Barecheck - Code coverage reportTotal: 96.31%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
julianstirling
approved these changes
Mar 4, 2026
The test `test_thread_with_invocation_id_cancellation_propagates` was failing because I'd set too long a poll interval. This commit drops the poll interval, and it appears to work OK. I have realised we could probably do with a timeout as well as a poll interval: I suspect my intention was to set a timeout of 1 second, not a poll interval of 1 second! The argument was clearly named though - so I don't think we need to change the function.
This was causing some warnings in the test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
test_thread_with_invocation_id_cancellation_propagateswas failing because I'd set too long a poll interval. This commit drops the poll interval, and it appears to work OK.I have realised we could probably do with a timeout as well as a poll interval: I suspect my intention was to set a timeout of 1 second, not a poll interval of 1 second! The argument was clearly named though - so I don't think we need to change the function.
This is a trivial fix, and the randomly failing tests were getting really annoying!