Add a CI job to test against the OFM test suite#280
Conversation
This should help catch issues earlier - it means if modifications to OFM are needed, this will be flagged early. It would be nice to keep an OFM branch that's updated with necessary changes for LabThings to work nicely, but this is unlikely to be an automatic thing. For now, I think just being able to check whether the current OFM codebase will work (unmodified) with changes being proposed to LabThings is already helpful.
Barecheck - Code coverage reportTotal: 96.52%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
This is needed for OFM unit tests.
This is required for the lifecycle test to complete.
|
I'll squash and merge this - wouldn't have all those commits if I weren't testing CI! |
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
Really nice. Couple of teeny suggestions.
Thanks to @julianstirling for code review.
|
Just in the interests of setting expectations, my current thinking is that this is a useful check, but isn't something I'd hold up PRs for without good reason. @julianstirling commented along these lines in #279. If we need OFM changes for this test to pass, that might block release but shouldn't block merging as a general rule. Of course, if a PR comes with a modified branch of the server, that's great - but we will then need to figure out a way to manage which branch we test against. |
|
I see some warnings in the tests, but I also see them when running locally and in the CI logs on the OFM server repo as well, so I think they are nothing to worry about. The three relevant jobs should all show up, for example, here: https://gitlab.com/openflexure/openflexure-microscope-server/-/pipelines/2364151179 |
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
An enthusiastic yes from me.
2 participants
This should help catch issues earlier - it means if modifications to OFM are needed, this will be flagged early.
It would be nice to keep an OFM branch that's updated with necessary changes for LabThings to work nicely, but this is unlikely to be an automatic thing. For now, I think just being able to check whether the current OFM codebase will work (unmodified) with changes being proposed to LabThings is already helpful.