-
Notifications
You must be signed in to change notification settings - Fork 174
fix(BA-6035): split RouteHealthRecord into ReplicaProbeTarget + ReplicaHealthStatus #11632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5e1a1ab
feat(BA-6035): define RouteProbeTarget and RouteHealthStatus Valkey t…
HyeockJinKim 24ad9e2
feat(BA-6035): add RouteProbeTarget/RouteHealthStatus Valkey client m…
HyeockJinKim 2fa5c0d
feat(BA-6035): add health_check to RoutingRow and refactor Deployment…
HyeockJinKim 25ca363
fix(BA-6035): backfill health_check on routings from revision model_d…
HyeockJinKim d533350
fix(BA-6035): replace health records with TTL-based statuses in check…
HyeockJinKim 79283c9
fix(BA-6035): update RouteHealthObserver to use ReplicaProbeTarget + …
HyeockJinKim cda42ff
fix(BA-6035): add ReplicaProbeTargetSyncHandler and fix AppProxy sync…
HyeockJinKim c07043f
fix(BA-6035): delete RouteHealthRecord and legacy Valkey health methods
HyeockJinKim 8c7834a
fix(BA-6035): fix remaining tests using old DeploymentInfo fields
HyeockJinKim d3dc32b
fix(BA-6035): remove remaining model_revisions from coordinator histo…
HyeockJinKim 3e3d480
changelog: add news fragment for PR #11632
HyeockJinKim 6f50520
fix(BA-6035): rebase migration c3d4e5f6a7b8 onto b2d4f6e8c1a3
HyeockJinKim 5c102fc
fix(BA-6035): treat no-health-check RUNNING routes as healthy in roll…
HyeockJinKim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Split route health Valkey record into ReplicaProbeTarget (probe config) and ReplicaHealthStatus (TTL-based result), removing initial_delay from Valkey and switching to DB-based timeout in check_warming_up_health. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title says "fix," but the news fragment says "enhance," so I think we need to standardize this.