sigrokdriver: fix TypeError in stop() by passing bytes to communicate()#1850
Open
xistadi wants to merge 1 commit intolabgrid-project:masterfrom
Open
sigrokdriver: fix TypeError in stop() by passing bytes to communicate()#1850xistadi wants to merge 1 commit intolabgrid-project:masterfrom
xistadi wants to merge 1 commit intolabgrid-project:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1850 +/- ##
======================================
Coverage 45.8% 45.8%
======================================
Files 182 182
Lines 14718 14718
======================================
Hits 6743 6743
Misses 7975 7975
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
Hi, you will need to fix the DCO error by adding your |
Popen is opened without text=True so stdin is in binary mode. communicate(input=...) must receive bytes, not str. Fixes Python 3.11+ TypeError: memoryview requires bytes, not str. Fixes labgrid-project#1847 Signed-off-by: xistadi <xistadi@users.noreply.github.com>
f328d2d to
bda43fd
Compare
Author
Hey! Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Popen is opened without text=True so stdin is in binary mode. communicate(input=...) must receive bytes, not str. Fixes Python 3.11+ TypeError: memoryview requires bytes, not str.
Fixes #1847
SigrokDriver.stop()callsself._process.communicate(input="q"), butPopenis created withouttext=True, so stdin is in binary mode.On Python 3.11+, this raises:
TypeError: memoryview: a bytes-like object is required, not 'str'
Fix: pass
b"q"instead of"q".