Skip to content

OmniProtocol Rewrite #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cwilvx merged 26 commits into from
Mar 19, 2026

fix: incoherent tx on mempool merge

afc52a5
Select commit
Loading
Failed to load commit list.
Merged

OmniProtocol Rewrite #691

fix: incoherent tx on mempool merge
afc52a5
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 19, 2026 in 1m 17s

Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 374 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0FX6qBQcX3ClQ7g4g7&open=AZ0FX6qBQcX3ClQ7g4g7&pullRequest=691

Check failure on line 207 in src/libs/omniprotocol/transport/PeerConnection.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Provide a compare function that depends on "String.localeCompare", to reliably sort elements alphabetically. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjI4fUXOCXgUO_O&open=AZ0CbBjI4fUXOCXgUO_O&pullRequest=691

Check warning on line 342 in src/libs/omniprotocol/transport/ConnectionPool.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "peer". 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjt4fUXOCXgUO_W&open=AZ0CbBjt4fUXOCXgUO_W&pullRequest=691

Check warning on line 82 in src/libs/omniprotocol/integration/consensusAdapter.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBff4fUXOCXgUO_B&open=AZ0CbBff4fUXOCXgUO_B&pullRequest=691

Check warning on line 145 in src/libs/omniprotocol/integration/consensusAdapter.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBff4fUXOCXgUO_F&open=AZ0CbBff4fUXOCXgUO_F&pullRequest=691

Check warning on line 125 in src/libs/omniprotocol/transport/PeerConnection.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'rateLimiter' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjI4fUXOCXgUO_M&open=AZ0CbBjI4fUXOCXgUO_M&pullRequest=691

Check warning on line 5 in src/libs/omniprotocol/transport/PeerConnection.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `node:events` over `events`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjI4fUXOCXgUO_K&open=AZ0CbBjI4fUXOCXgUO_K&pullRequest=691

Check warning on line 187 in src/libs/omniprotocol/integration/consensusAdapter.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBff4fUXOCXgUO_I&open=AZ0CbBff4fUXOCXgUO_I&pullRequest=691

Check warning on line 197 in src/libs/omniprotocol/transport/PeerConnection.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjI4fUXOCXgUO_N&open=AZ0CbBjI4fUXOCXgUO_N&pullRequest=691

Check warning on line 761 in src/libs/omniprotocol/transport/PeerConnection.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to variable "connection". 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjI4fUXOCXgUO_P&open=AZ0CbBjI4fUXOCXgUO_P&pullRequest=691

Check warning on line 888 in src/libs/omniprotocol/transport/PeerConnection.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjI4fUXOCXgUO_S&open=AZ0CbBjI4fUXOCXgUO_S&pullRequest=691

Check warning on line 60 in src/libs/omniprotocol/transport/ConnectionPool.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'pendingConnections' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjt4fUXOCXgUO_V&open=AZ0CbBjt4fUXOCXgUO_V&pullRequest=691

Check warning on line 116 in src/libs/omniprotocol/integration/consensusAdapter.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBff4fUXOCXgUO_E&open=AZ0CbBff4fUXOCXgUO_E&pullRequest=691

Check warning on line 883 in src/libs/omniprotocol/transport/PeerConnection.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjI4fUXOCXgUO_R&open=AZ0CbBjI4fUXOCXgUO_R&pullRequest=691

Check warning on line 3 in src/libs/omniprotocol/transport/ConnectionPool.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `node:events` over `events`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjt4fUXOCXgUO_U&open=AZ0CbBjt4fUXOCXgUO_U&pullRequest=691

Check warning on line 797 in src/libs/omniprotocol/transport/PeerConnection.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjI4fUXOCXgUO_Q&open=AZ0CbBjI4fUXOCXgUO_Q&pullRequest=691

Check warning on line 175 in src/libs/omniprotocol/integration/consensusAdapter.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBff4fUXOCXgUO_H&open=AZ0CbBff4fUXOCXgUO_H&pullRequest=691

Check warning on line 618 in src/libs/omniprotocol/transport/ConnectionPool.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add an initial value to this "reduce()" call. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjt4fUXOCXgUO_Z&open=AZ0CbBjt4fUXOCXgUO_Z&pullRequest=691

Check warning on line 971 in src/index.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0FQPoLgVd7omoSNWkk&open=AZ0FQPoLgVd7omoSNWkk&pullRequest=691

Check warning on line 103 in src/libs/omniprotocol/integration/consensusAdapter.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBff4fUXOCXgUO_D&open=AZ0CbBff4fUXOCXgUO_D&pullRequest=691

Check warning on line 215 in src/libs/omniprotocol/integration/consensusAdapter.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBff4fUXOCXgUO_J&open=AZ0CbBff4fUXOCXgUO_J&pullRequest=691

Check failure on line 669 in src/libs/omniprotocol/transport/ConnectionPool.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBjt4fUXOCXgUO_a&open=AZ0CbBjt4fUXOCXgUO_a&pullRequest=691

Check warning on line 52 in src/libs/omniprotocol/integration/consensusAdapter.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBff4fUXOCXgUO_A&open=AZ0CbBff4fUXOCXgUO_A&pullRequest=691

Check warning on line 15 in src/libs/omniprotocol/ratelimit/RateLimiter.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'log'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBkQ4fUXOCXgUO_b&open=AZ0CbBkQ4fUXOCXgUO_b&pullRequest=691

Check warning on line 169 in src/libs/omniprotocol/integration/consensusAdapter.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ0CbBff4fUXOCXgUO_G&open=AZ0CbBff4fUXOCXgUO_G&pullRequest=691
View more details on SonarQubeCloud