Skip to content

Fix: Purge non-existent recent files from settings#1

Closed
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fix-recent-files-purge
Closed

Fix: Purge non-existent recent files from settings#1
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fix-recent-files-purge

Conversation

@google-labs-jules
Copy link
Copy Markdown

This change fixes a bug where non-existent files were not being purged from the recent files list in the application settings.

The _load_recent_files method was correctly filtering out deleted files from the list displayed in the 'Open Recent' menu, but it did not persist this cleaned list back to the QSettings. This resulted in the settings accumulating stale entries over time.

The fix ensures that after the recent files list is cleaned, the updated list is written back to the settings. A new test case has been added to verify this behavior.


PR created automatically by Jules for task 5845106026004285924

The `_load_recent_files` method was not updating the `QSettings` after filtering out non-existent files from the recent files list. This caused stale entries to persist in the configuration.

This commit corrects the behavior by saving the cleaned list back to the settings. It also introduces a new test case to verify that deleted file paths are correctly purged.
@google-labs-jules
Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

@kwrkb kwrkb closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant