Skip to content

Remove O_DIRECT since we don't have aligned data #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pobthebuilder wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove O_DIRECT since we don't have aligned data #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e2c8be
remove O_DIRECT since we don't have aligned data
pobthebuilder Mar 19, 2026
57e5766
fix type of data to satisfy the compiler
pobthebuilder Mar 19, 2026
c8d328f
updated defs
pobthebuilder Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/persistentNodeCache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ class PersistentNodeCache extends node_cache_1.default {
}
const appendData = fs_1.default.readFileSync(this.appendFilePath, 'utf-8');
appendData.split(/\r?\n/).forEach((line) => {
if (line.length == 0) {
return;
}
let data = this.serializer.deserialize(line);
switch (data['cmd']) {
case 'set':
Expand Down Expand Up @@ -185,7 +188,7 @@ class PersistentNodeCache extends node_cache_1.default {
}
appendToFile(fileName, data) {
this.changesSinceLastBackup = true;
const flags = fs_1.default.constants.O_WRONLY | fs_1.default.constants.O_DIRECT | fs_1.default.constants.O_APPEND;
const flags = fs_1.default.constants.O_WRONLY | fs_1.default.constants.O_APPEND;
const mode = 0o666;
if (this.appendFileDescriptor) {
fs_1.default.write(this.appendFileDescriptor, data, 0, data.length, null, (writeErr, written, buffer) => {
Expand Down
4 changes: 2 additions & 2 deletions lib/waitFor.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export declare const waitFor: <Event_1 extends string>(event: Event_1, emitter: EventEmitter<Event_1>, callback?: Callback) => Promise<void>;
export declare const removeListener: <Event_1 extends string>(emitter: EventEmitterOff<Event_1> | EventEmitterRemoveListener<Event_1>, event: "error" | Event_1, listener: EventListener) => void;
export declare const waitFor: <Event extends string>(event: Event, emitter: EventEmitter<Event>, callback?: Callback) => Promise<void>;
export declare const removeListener: <Event extends string>(emitter: EventEmitterOff<Event> | EventEmitterRemoveListener<Event>, event: Event | "error", listener: EventListener) => void;
interface Callback {
(error: any): void;
}
Expand Down
6 changes: 3 additions & 3 deletions src/persistentNodeCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,11 @@ export default class PersistentNodeCache extends NodeCache {

private appendToFile(fileName: string, data: Buffer): void {
this.changesSinceLastBackup = true;
const flags = fs.constants.O_WRONLY | fs.constants.O_DIRECT | fs.constants.O_APPEND;
const flags = fs.constants.O_WRONLY | fs.constants.O_APPEND;
const mode = 0o666;

if(this.appendFileDescriptor) {
fs.write(this.appendFileDescriptor, data, 0, data.length, null, (writeErr, written, buffer) => {
fs.write(this.appendFileDescriptor, data as Uint8Array, 0, data.length, null, (writeErr, written, buffer) => {
if (writeErr) {
console.error('Error writing to file:', writeErr);
}
Expand All @@ -236,7 +236,7 @@ export default class PersistentNodeCache extends NodeCache {
return;
}
this.appendFileDescriptor = fd;
fs.write(fd, data, 0, data.length, null, (writeErr, written, buffer) => {
fs.write(fd, data as Uint8Array, 0, data.length, null, (writeErr, written, buffer) => {
if (writeErr) {
console.error('Error writing to file:', writeErr);
}
Expand Down
Loading