[DEV-1658] Support projection v2 engine#229
Merged
Merged
Conversation
Review Summary by QodoAdd projection engine version selection support
WalkthroughsDescription• Adds ProjectionEngineVersion enum supporting V1 and V2 engines • Introduces engine_version field to projection creation options • Implements builder method for setting engine version preference • Updates protobuf schema to include engine version parameter Diagramflowchart LR
A["ProjectionEngineVersion enum<br/>V1 default, V2 option"] --> B["CreateProjectionOptions<br/>engine_version field"]
B --> C["ProjectionClient<br/>passes to protobuf"]
C --> D["projections.proto<br/>engine_version parameter"]
File Changes1. kurrentdb/src/options/projections.rs
|
Code Review by Qodo
1. V1 sent as non-zero
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for selecting the V2 projection engine when creating a projection via a new engine version option. V1 remains the default.
Closes DEV-1658.