Skip to content

chore: update docker image to kurrentplatform/kurrentdb#386

Merged
w1am merged 1 commit into
trunkfrom
w1am/dev-1428-replace-image-in-compose-file
Apr 29, 2026
Merged

chore: update docker image to kurrentplatform/kurrentdb#386
w1am merged 1 commit into
trunkfrom
w1am/dev-1428-replace-image-in-compose-file

Conversation

@w1am
Copy link
Copy Markdown
Contributor

@w1am w1am commented Apr 29, 2026

Summary

  • Updates the docker-compose image reference from docker.kurrent.io/eventstore/eventstoredb-ee to kurrentplatform/kurrentdb defaults.

Closes DEV-1428

@linear
Copy link
Copy Markdown

linear Bot commented Apr 29, 2026

@qodo-code-review
Copy link
Copy Markdown

Review Summary by Qodo

Update docker-compose to use kurrentplatform image

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Updates docker-compose image registry to kurrentplatform
• Changes default image from eventstoredb-ee to kurrentdb
• Modernizes container image references for consistency
Diagram
flowchart LR
  old["docker.kurrent.io/eventstore/eventstoredb-ee"]
  new["kurrentplatform/kurrentdb"]
  old -- "registry & image update" --> new
Loading

Grey Divider

File Changes

1. docker-compose.yml ⚙️ Configuration changes +1/-1

Update EventStoreDB image registry and name

• Updates KURRENTDB_DOCKER_REGISTRY default from docker.kurrent.io/eventstore to kurrentplatform
• Updates KURRENTDB_DOCKER_IMAGE default from eventstoredb-ee to kurrentdb
• Maintains existing KURRENTDB_DOCKER_TAG default value of lts

docker-compose.yml


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown

qodo-code-review Bot commented Apr 29, 2026

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Context used
✅ Tickets: DEV-1428

Grey Divider


Remediation recommended

1. Registry var semantics drift 🐞 Bug ⚙ Maintainability
Description
docker-compose.yml now defaults KURRENTDB_DOCKER_REGISTRY to kurrentplatform, which is a
Docker Hub namespace/prefix (Docker implicitly treats it as docker.io/kurrentplatform), not a
registry host. Because the repo/workflows describe this value as “Docker registry”, users are likely
to set it to a host-only value (e.g. docker.kurrent.io), producing an invalid image reference like
docker.kurrent.io/kurrentdb:lts and breaking docker compose up.
Code

docker-compose.yml[27]

+    image: ${KURRENTDB_DOCKER_REGISTRY:-kurrentplatform}/${KURRENTDB_DOCKER_IMAGE:-kurrentdb}:${KURRENTDB_DOCKER_TAG:-lts}
Evidence
The compose image string uses KURRENTDB_DOCKER_REGISTRY as the entire first path segment/prefix
before the image name, so it must include any required namespace (and optionally a registry host).
However, CI configuration terminology calls this value “The Docker registry” and passes it through
KURRENTDB_DOCKER_REGISTRY, increasing the risk that developers interpret it as host-only and set
it incorrectly.

docker-compose.yml[26-28]
.github/workflows/load-configuration.yml[14-20]
.github/workflows/tests.yml[111-123]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`KURRENTDB_DOCKER_REGISTRY` is used as an *image prefix* (optionally `registryHost/namespace`, or just `namespace` for Docker Hub), but it’s named/described like a registry host. With the new default (`kurrentplatform`), this mismatch is more likely to cause incorrect overrides and image pull failures.

### Issue Context
Docker interprets `kurrentplatform/kurrentdb:...` as `docker.io/kurrentplatform/kurrentdb:...`, so the default is a namespace. But if a user sets `KURRENTDB_DOCKER_REGISTRY=docker.kurrent.io` expecting “registry host”, the composed image becomes `docker.kurrent.io/kurrentdb:...` (missing a namespace).

### Fix Focus Areas
- docker-compose.yml[26-28]
- .github/workflows/load-configuration.yml[14-20]

### Suggested fix
- Add an inline comment in `docker-compose.yml` explaining that `KURRENTDB_DOCKER_REGISTRY` is an image prefix (e.g., `docker.io/kurrentplatform` or `docker.kurrent.io/eventstore`).
- Optionally adjust workflow output descriptions from “Docker registry” to “image prefix (registry/namespace)” to match actual usage.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@w1am w1am merged commit 17ec29d into trunk Apr 29, 2026
68 of 70 checks passed
@w1am w1am deleted the w1am/dev-1428-replace-image-in-compose-file branch April 29, 2026 11:54
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w1am 👉 Created pull request targeting release/v1.1: #387

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w1am 👉 Created pull request targeting release/v1.2: #388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant