Skip to content

Rename lookup_parser to lookup_loader #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kurotych merged 1 commit into from
Nov 8, 2025
+7 −7
Merged

Rename lookup_parser to lookup_loader #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ pub trait ViewGenerator {
) -> Result<String, SqlantError>;
}

pub async fn lookup_parser(
pub async fn lookup_loader(
connection_string: &str,
schema_name: String,
) -> Result<Box<dyn SqlERDataLoader>, SqlantError> {
Expand Down
4 changes: 2 additions & 2 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use std::str::FromStr;

use clap::ArgMatches;
use sqlant::{get_generator, lookup_parser, Direction, GeneratorConfigOptions, GeneratorType};
use sqlant::{get_generator, lookup_loader, Direction, GeneratorConfigOptions, GeneratorType};

fn get_arg(args: &ArgMatches, arg_name: &str) -> String {
args.get_one::<String>(arg_name).unwrap().to_string()
Expand All @@ -11,7 +11,7 @@ fn get_arg(args: &ArgMatches, arg_name: &str) -> String {
async fn main() {
let args = sqlant::cli::parse();

let mut s = lookup_parser(
let mut s = lookup_loader(
&get_arg(&args, "connection_string"),
get_arg(&args, "schema"),
)
Expand Down
4 changes: 2 additions & 2 deletions tests/sql_loader_custom_schema_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
use sqlant::{lookup_parser, sql_entities::ColumnConstraints::*, sql_entities::*};
use sqlant::{lookup_loader, sql_entities::ColumnConstraints::*, sql_entities::*};
use std::{collections::BTreeMap, env};

mod utils;
use crate::utils::check_fk;

async fn load_erd() -> SqlERData {
let con_string = env::var("CON_STRING").unwrap();
let mut parser = lookup_parser(&con_string, "test_schema".to_string())
let mut parser = lookup_loader(&con_string, "test_schema".to_string())
.await
.unwrap();
parser.load_erd_data().await.unwrap()
Expand Down
4 changes: 2 additions & 2 deletions tests/sql_loader_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use sqlant::{lookup_parser, sql_entities::ColumnConstraints::*, sql_entities::*};
use sqlant::{lookup_loader, sql_entities::ColumnConstraints::*, sql_entities::*};
use std::sync::Arc;
use std::{
collections::{BTreeMap, BTreeSet},
Expand All @@ -10,7 +10,7 @@ use crate::utils::check_fk;

async fn load_erd() -> SqlERData {
let con_string = env::var("CON_STRING").unwrap();
let mut parser = lookup_parser(&con_string, "public".to_string())
let mut parser = lookup_loader(&con_string, "public".to_string())
.await
.unwrap();
parser.load_erd_data().await.unwrap()
Expand Down