Skip to content

clusterloader2: add CL2_TOLERATION override to all workload templates#3900

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
wonderyl:taint
Apr 17, 2026
Merged

clusterloader2: add CL2_TOLERATION override to all workload templates#3900
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
wonderyl:taint

Conversation

@wonderyl
Copy link
Copy Markdown
Contributor

@wonderyl wonderyl commented Mar 18, 2026

What this PR does / why we need it:

Allows CL2 to run on tainted nodes.

Details

Adds a new CL2_TOLERATION parameter that, when set to a non-empty string, adds a toleration, with operator: Exists and effect: NoSchedule, using that string as the key. This allows directing all workloads to tainted nodes.
This feature unblocks the use of Kwok virtual nodes.

Applies to: Deployment, StatefulSet, DaemonSet, Job (reconcile-objects) and simple-deployment (scheduler-throughput / huge-service).

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 18, 2026
@k8s-ci-robot k8s-ci-robot requested review from mborsz and wojtek-t March 18, 2026 05:55
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Mar 18, 2026 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: wonderyl / name: Lei Yao (4031245)

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 18, 2026

Hi @wonderyl. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2026
@wonderyl wonderyl force-pushed the taint branch 2 times, most recently from d72745e to 3fd9dab Compare March 18, 2026 06:01
@wonderyl
Copy link
Copy Markdown
Contributor Author

wonderyl commented Mar 18, 2026

/easycla

1 similar comment
@wonderyl
Copy link
Copy Markdown
Contributor Author

wonderyl commented Mar 18, 2026

/easycla

@Qqkyu
Copy link
Copy Markdown
Contributor

Qqkyu commented Mar 18, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2026
@wonderyl
Copy link
Copy Markdown
Contributor Author

wonderyl commented Mar 21, 2026

/easycla

@wonderyl
clusterloader2: add CL2_TOLERATION override to all workload templates
4031245 
Add a new CL2_TOLERATION parameter that, when set to a non-empty string,
adds a toleration with operator: Exists and effect: NoSchedule using that
string as the key. This allows directing all workloads to any arbitrarily
tainted node without needing a dedicated override per taint type.

Applies to: Deployment, StatefulSet, DaemonSet, Job (reconcile-objects)
and simple-deployment (scheduler-throughput / huge-service).
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 21, 2026
@wonderyl
Copy link
Copy Markdown
Contributor Author

wonderyl commented Apr 9, 2026

@mborsz , @wojtek-t
I would appreciate if you could take some time to take a look. This is a relatively straight forward PR.

Qqkyu
Qqkyu reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Qqkyu Qqkyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Qqkyu, wonderyl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2026
@k8s-ci-robot k8s-ci-robot merged commit d0048e8 into kubernetes:master Apr 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

1 more reviewer

@Qqkyu Qqkyu Qqkyu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Qqkyu Qqkyu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wonderyl @k8s-ci-robot @Qqkyu