Skip to content

Adjust check probes timeout for huge clusters#3898

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
kamilWyszynski1:adjust-probes-interval-timeout-for-big-clusters
Mar 27, 2026
Merged

Adjust check probes timeout for huge clusters#3898
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
kamilWyszynski1:adjust-probes-interval-timeout-for-big-clusters

Conversation

@kamilWyszynski1
Copy link
Copy Markdown
Contributor

@kamilWyszynski1 kamilWyszynski1 commented Mar 17, 2026

This PR adjusts prometheus probes check interval for clusters with 5k or more nodes.

For such clusters, we observed InClusterNetworkLatency to be failing due to timeouts in individual probe's checks, what's more even if the response from prometheus was successful, check was time outing during parsing.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Mar 17, 2026 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kamilWyszynski1 / name: Kamil Wyszyński (af1f883)

@k8s-ci-robot k8s-ci-robot requested review from mborsz and wojtek-t March 17, 2026 07:48
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 17, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 17, 2026

Hi @kamilWyszynski1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 17, 2026
@Qqkyu
Copy link
Copy Markdown
Contributor

Qqkyu commented Mar 18, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2026
Qqkyu
Qqkyu reviewed Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Qqkyu Qqkyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 19, 2026
@kamilWyszynski1
Copy link
Copy Markdown
Contributor Author

kamilWyszynski1 commented Mar 19, 2026

/assign @marseel

@kamilWyszynski1
Copy link
Copy Markdown
Contributor Author

kamilWyszynski1 commented Mar 25, 2026

@marseel could you have a look please?

marseel
marseel reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@marseel marseel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

Comment thread clusterloader2/pkg/measurement/common/probes/probes.go Outdated
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2026
@kamilWyszynski1 kamilWyszynski1 force-pushed the adjust-probes-interval-timeout-for-big-clusters branch from c8ed509 to af1f883 Compare March 27, 2026 10:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2026
@kamilWyszynski1 kamilWyszynski1 requested a review from marseel March 27, 2026 10:24
@kamilWyszynski1
Copy link
Copy Markdown
Contributor Author

kamilWyszynski1 commented Mar 27, 2026

/retest

@kamilWyszynski1
Copy link
Copy Markdown
Contributor Author

kamilWyszynski1 commented Mar 27, 2026

/test pull-perf-tests-ec2-master-scale-performance-100

@marseel
Copy link
Copy Markdown
Member

marseel commented Mar 27, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kamilWyszynski1, marseel, Qqkyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8ac91b9 into kubernetes:master Mar 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@marseel marseel Awaiting requested review from marseel

1 more reviewer

@Qqkyu Qqkyu Qqkyu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@marseel marseel

@Qqkyu Qqkyu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kamilWyszynski1 @k8s-ci-robot @Qqkyu @marseel