fix: pass NodeList to processAllNodesForRule in tests

[sahitya-chandra]

Description

main is currently broken. Lint, Tests and E2E all fail at go vet:

vet: internal/controller/nodereadinessrule_controller_test.go:1881:58: not enough arguments in call to failController.processAllNodesForRule
	have (context.Context, *NodeReadinessRule)
	want (context.Context, *NodeReadinessRule, *corev1.NodeList)

#226 changed processAllNodesForRule to take a *corev1.NodeList, but the two new tests added in #216 still call it with the old two-argument signature. Both PRs were green on their own branches; the test file only stopped compiling once #216 landed on top of #226 on main.

Fix wraps the test node in a *corev1.NodeList and passes it through, same as reconcileNormal does. Filtering still happens inside the function, so behaviour is unchanged.

Related Issue

None

Type of Change

/kind bug
/kind failing-test

Testing

• make lint clean
• make test passes

Checklist

• make test passes
• make lint passes

Does this PR introduce a user-facing change?

NONE

[netlify]

✅ Deploy Preview for node-readiness-controller canceled.

Name	Link
🔨 Latest commit	145d2ac
🔍 Latest deploy log	https://app.netlify.com/projects/node-readiness-controller/deploys/6a06e4155057340008064f35

[k8s-ci-robot]

Hi @sahitya-chandra. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[AvineshTripathi]

/ok-to-test

[ajaysundark]

Thanks @sahitya-chandra !

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajaysundark, sahitya-chandra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ajaysundark]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment