Skip to content

Skip eviction in case when the Node is NotReady#2002

Draft
kron4eg wants to merge 1 commit intokubermatic:mainfrom
kron4eg:not-ready-eviction
Draft

Skip eviction in case when the Node is NotReady#2002
kron4eg wants to merge 1 commit intokubermatic:mainfrom
kron4eg:not-ready-eviction

Conversation

@kron4eg
Copy link
Member

@kron4eg kron4eg commented Feb 27, 2026

What this PR does / why we need it:
When the Node is in NotReady condition, it's useless to try to drain it, causes endless loop of drain retrying of half-dead Node.

Which issue(s) this PR fixes:
Fixes #1586

What type of PR is this?
/kind bug
Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Skip eviction in case when the Node is NotReady

Documentation:

NONE

Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Feb 27, 2026
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adoi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2026
@kubermatic-bot
Copy link
Contributor

@kron4eg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-test db2723b link true /test pull-machine-controller-test

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kron4eg kron4eg marked this pull request as draft February 27, 2026 13:49
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't try to drain NotReady nodes

2 participants