Skip to content

Skip VOD/series during scans when hide toggle is on#193

Merged
kristofferR merged 1 commit into
mainfrom
feat/hide-vod-skip-scan
May 7, 2026
Merged

Skip VOD/series during scans when hide toggle is on#193
kristofferR merged 1 commit into
mainfrom
feat/hide-vod-skip-scan

Conversation

@kristofferR
Copy link
Copy Markdown
Owner

Summary

  • The Hide VOD / series entries setting (hide_vod_content) was frontend-display-only — the scan still probed every movie/series and exports leaked them, even though the setting description promised otherwise.
  • Pushed the filter into the scan pipeline: ScanConfig now carries hide_vod_content, and a new filter_channels_by_content_type helper drops non-Live channels alongside the existing selection filter before the run begins.
  • Exports follow naturally (they operate on scan results), and the existing display filter for the loaded preview is unchanged — toggling stays instant, no re-parse.

Test plan

  • cargo test --lib — 214 passing, including new content_type_filter_keeps_all_when_disabled and content_type_filter_drops_movies_and_series_when_enabled
  • bun run typecheck — clean
  • Load a mixed playlist (live + movies + series). With Hide VOD / series entries OFF, start a scan and confirm movies/series are probed
  • Toggle Hide VOD / series entries ON, start a scan, confirm only live channels are probed (scan total matches live count, no movie/series scan://channel-result events fire)
  • Export results (CSV / M3U) and confirm no VOD/series rows in the output
  • Toggle the setting between scans on the same loaded playlist and confirm no re-parse is required

The "Hide VOD / series entries" setting only filtered the displayed
preview, so scans still probed every movie/series and exports leaked
them. Push the filter into the scan pipeline: pass hide_vod_content in
ScanConfig and drop non-Live channels alongside the selection filter
before the run begins.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Warning

Rate limit exceeded

@kristofferR has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 3 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bc0e504c-5bde-4534-b9ce-1fcfbb909d85

📥 Commits

Reviewing files that changed from the base of the PR and between 01003eb and acc6a5d.

📒 Files selected for processing (5)
  • src-tauri/src/commands/history.rs
  • src-tauri/src/commands/scan.rs
  • src-tauri/src/models/scan.rs
  • src/App.tsx
  • src/lib/types.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/hide-vod-skip-scan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kristofferR kristofferR merged commit de47065 into main May 7, 2026
7 of 8 checks passed
@kristofferR kristofferR deleted the feat/hide-vod-skip-scan branch May 7, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant