Fix issue #20: reset sentence color on text change (line number only)#41
Fix issue #20: reset sentence color on text change (line number only)#41jaybutani1793 wants to merge 7 commits intokovzol:masterfrom
Conversation
Remove sentence_set_bg() calls from evaluate_line() that were painting the entire entry widget background green/red on evaluation. The line number foreground color (gtk_widget_override_color on sen->line_no) already provides the correct visual feedback — only the line number text changes color (green=true, red=error), leaving the row background untouched. Also remove the matching sentence_set_bg(BG_COLOR_DEFAULT) reset in sentence_text_changed() since we no longer paint the entry background.
|
Thanks for pointing this out! To better align with the previous behavior, I’ll refine the approach as follows: Preserve the existing background coloring logic for line numbers (like conclusions) This should keep the UI consistent with the original design while still solving issue #20 properly. |
fc21072 to
69c8a83
Compare
9439158 to
336b202
Compare
jaybutani1793
left a comment
There was a problem hiding this comment.
Thanks for the suggestion! I’ve updated the implementation to preserve existing background coloring and use only text color for evaluation. Editing now resets only the evaluation state. Also removed unintended file changes. This should now align with previous behavior and fix issue #20.
|
Thanks, I'll have a look soon. |

Fix issue #20: reset sentence color on text change
Problem
Currently, after evaluating a sentence, the entire line background is colored (red/green).
However, according to the expected behavior:
Additionally, the color was not resetting when the sentence text was modified.
Solution
setForeground()instead ofsetBackground()Result
Testing