Skip to content

Upgrade base to 22.04 and add koremarkable-aarch64#117

Closed
NoaHimesaka1873 wants to merge 2 commits intokoreader:masterfrom
NoaHimesaka1873:master
Closed

Upgrade base to 22.04 and add koremarkable-aarch64#117
NoaHimesaka1873 wants to merge 2 commits intokoreader:masterfrom
NoaHimesaka1873:master

Conversation

@NoaHimesaka1873
Copy link
Copy Markdown

@NoaHimesaka1873 NoaHimesaka1873 commented Apr 21, 2025

20.04 is now gone :( RIP


This change is Reviewable

@benoit-pierre
Copy link
Copy Markdown
Member

20.04 is not gone: it's getting phased out as a supported runner on Github Actions, but we can still use our docker image.

@benoit-pierre
Copy link
Copy Markdown
Member

Anyway, if we do switch to 22.04 (which might not be a good thing for our AppImage compatibility with older systems), then the code in baseimage-22.04/xxx needs to be brought up-to-date: basically to copy what's done for baseimage-20.04.

As for remarkable-pro|aarch64 support, do we really want a new dedicated image? Or should we just add the toolchain to the koremarkable image (like it's done for kokindle, which includes our 4 kindle toolchains).

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Apr 21, 2025

Or should we just add the toolchain to the koremarkable image (like it's done for kokindle, which includes our 4 kindle toolchains).

That's probably easier to deal with. 👍

@NoaHimesaka1873
Copy link
Copy Markdown
Author

Yeah it should be merged into remarkable image. Will edit asap.

@benoit-pierre
Copy link
Copy Markdown
Member

No need: #118 will update the baseimage, I'll update the derived images after, hopefully with a new koxtoolchain release once koreader/koxtoolchain#52 gets sorted.

@NoaHimesaka1873
Copy link
Copy Markdown
Author

Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants