Open
Conversation
| .Select(ProcessRequestAsync) | ||
| .ToList(); | ||
|
|
||
| var delayTask = Task.Delay(timeout); |
There was a problem hiding this comment.
По-хорошему delayTask бы создать до всех ProcessRequestAsync. Иначе выходит, что запросы уже какое-то время как отправлены
| var request = CreateRequest(uri + "?query=" + query); | ||
| var requestTimer = Stopwatch.StartNew(); | ||
| var task = ProcessRequestAsync(request); | ||
| var delayTask = Task.Delay(currentReplicaTimeout); |
There was a problem hiding this comment.
timeLeft и currentReplicaTimeout могут оказаться отрицательными. Task.Delay может или выбросить исключение, или, с маленьким шансом, превратиться в никогда не заканчивающуюся таску
| tasks.Remove(finishedTask); | ||
| if (tasks.Count == 0 || i < ReplicaAddresses.Length - 1) | ||
| { | ||
| goto next; |
| var delayTask = Task.Delay(timeToNextLaunch); | ||
| var completedTask = await Task.WhenAny(Task.WhenAny(tasks), delayTask); | ||
|
|
||
| if (completedTask != delayTask) |
There was a problem hiding this comment.
Если реплики будут тормозить, то соответствующие таски так и останутся в tasks, и статистика для них не обновится
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.