Open
Conversation
a-zhelonkin
reviewed
Nov 21, 2025
Comment on lines
+13
to
+23
| string result; | ||
| if (str.Length > maxLength) | ||
| { | ||
| result = str.Substring(0, maxLength); | ||
| } | ||
| else | ||
| { | ||
| result = str; | ||
| } | ||
|
|
||
| return result; |
There was a problem hiding this comment.
nit: можно заменить result на return и/или схлопнуть в тернарник
| [SetUp] | ||
| public void Setup() | ||
| { | ||
| testPerson = new Person |
There was a problem hiding this comment.
nit: я бы вынес это в статическую фабрику, так бы получилась более явная гарантия, что между тестами не остается общих данных
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="FluentAssertions" Version="8.8.0" /> |
There was a problem hiding this comment.
Точно ли это здесь нужно? Эта зависимость обычно используется только для тестов
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="FluentAssertions" Version="8.8.0" /> |
|
|
||
| namespace ObjectPrinting | ||
| { | ||
| public class ObjectPrinter |
|
|
||
| namespace ObjectPrinting | ||
| { | ||
| public class PrintingConfig<TOwner> |
There was a problem hiding this comment.
nit: Обычно делаю все классы по умолчанию sealed. Это такая холиварная нанооптимизация + заставляет лишний раз подумать, прежде чем расширять какой-либо класс
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@a-zhelonkin