Ading a sync-ed variant of "HttpRequest.send"#10
Open
3Nigma wants to merge 4 commits intokodart:masterfrom
Open
Ading a sync-ed variant of "HttpRequest.send"#103Nigma wants to merge 4 commits intokodart:masterfrom
3Nigma wants to merge 4 commits intokodart:masterfrom
Conversation
… the "HttpUrlonnectionRequest" implementation. Transformed the "ResponseHandler" into an interface so that it becomes easily to write "<Http instance>. [...] .handler(this).send()" which makes the code more readable.
… the "HttpUrlConnectionRequest" implementation. Transformed the "ResponseHandler" into an interface so that it becomes easily to write "<Http instance>. [...] .handler(this).send()" which makes the code more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
Thank you for taking the time to review this. I present to you 2 modifications that aided me using Httpzoid in my project:
[features not present in this pull request] As a side note, I've also implemented my own "HttpSerializer" that processes JSON using a GsonBuilder factory reference. This allows for custom JSON data serialization via the "GsonBuilder.registerTypeAdapter". To make this possible, I've also made a custom "HttpFactory" that ties everything together. Maybe it's a good thing, I don't know, but it helped me so maybe it can also help others.
That's it for now,
Thank you for the library, it's grait!,
Vic