fix: improve dev setup time and container size#3515
Merged
Conversation
isTravis
approved these changes
Mar 3, 2026
Member
isTravis
left a comment
There was a problem hiding this comment.
Am I understanding the diff correctly? It seems like we already were just mounting the main app folder. So the dev pnpm install was redundant and unnecessary? Looks like everything is a removal on that front, rather than any new mounts.
What a time saver!
Member
Author
yes that's correct! I think that was added previously bc of this specific incompatibility between some node_modules, but this should work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
I keep running out of space on my Mac bc of the anonymous
/app/node_modulesvolume.I simplified the dev setup to just mount the main folder, that way we don't need to run a
pnpm installin the dev container itself.This takes the dev startup time from a couple of minutes to like 10 seconds for me, as well as saving a lot of space.
Test Plan
pnpm devScreenshots (if applicable)
Optional
Notes/Context/Gotchas
I added the
@esbuuild/linux-arm64devDep bc otherwiseesbuild-loadercomplains that you have the MacOS version ofesbuildinstalled when running in the container.This assumes all devs run an ARM machine. We could also add the
@esbuild/linux-amd64devDep if we a have a dev that doesn't have an ARM device.We could also only add
@esbuild/linux-amd64and addplatform: linux/amd64to thedocker-compose.dev.yml, to run the dev container in a more similar way to the prod one, but that would probably be more resource intensive/slower to run for us Mac using devs.