Skip to content

fix: improve dev setup time and container size#3515

Merged
tefkah merged 2 commits intomainfrom
tfk/improve-dev
Mar 4, 2026
Merged

fix: improve dev setup time and container size#3515
tefkah merged 2 commits intomainfrom
tfk/improve-dev

Conversation

@tefkah
Copy link
Member

@tefkah tefkah commented Mar 3, 2026

Issue(s) Resolved

I keep running out of space on my Mac bc of the anonymous /app/node_modules volume.

I simplified the dev setup to just mount the main folder, that way we don't need to run a pnpm install in the dev container itself.

This takes the dev startup time from a couple of minutes to like 10 seconds for me, as well as saving a lot of space.

Test Plan

  1. Run pnpm dev
  2. Observe normal dev env

Screenshots (if applicable)

Optional

Notes/Context/Gotchas

I added the @esbuuild/linux-arm64 devDep bc otherwise esbuild-loader complains that you have the MacOS version of esbuild installed when running in the container.
This assumes all devs run an ARM machine. We could also add the @esbuild/linux-amd64 devDep if we a have a dev that doesn't have an ARM device.

We could also only add @esbuild/linux-amd64 and add platform: linux/amd64 to the docker-compose.dev.yml, to run the dev container in a more similar way to the prod one, but that would probably be more resource intensive/slower to run for us Mac using devs.

@tefkah tefkah requested a review from isTravis March 3, 2026 14:06
Copy link
Member

@isTravis isTravis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understanding the diff correctly? It seems like we already were just mounting the main app folder. So the dev pnpm install was redundant and unnecessary? Looks like everything is a removal on that front, rather than any new mounts.

What a time saver!

@tefkah
Copy link
Member Author

tefkah commented Mar 4, 2026

Am I understanding the diff correctly? It seems like we already were just mounting the main app folder. So the dev pnpm install was redundant and unnecessary? Looks like everything is a removal on that front, rather than any new mounts.

What a time saver!

yes that's correct! I think that was added previously bc of this specific incompatibility between some node_modules, but this should work!

@tefkah tefkah merged commit 84e20e9 into main Mar 4, 2026
1 check passed
@tefkah tefkah deleted the tfk/improve-dev branch March 4, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants