ci: skip functions workflow on doc-only changes#3833
Conversation
Add paths-ignore to push and pull_request triggers to avoid running the full CI suite (unit, template, integration, e2e) when only documentation or non-code files are modified.
Use root-only *.md instead of **/*.md so template and testdata markdown still trigger CI. Replace CODEOWNERS with OWNERS and OWNERS_ALIASES to match repo ownership files.
Introduce a new GitHub Actions workflow to perform prechecks on code changes, including linting and schema validation. This workflow triggers on pushes and pull requests to the main branch.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
Bot
added
size/M
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds workflow filtering and a new CI “Check” workflow to reduce unnecessary runs and enforce repository checks on main/PRs.
Changes:
- Add
paths-ignorefilters to the existingfunctions.yamlworkflow for push and PR events. - Introduce a new
.github/workflows/ci-check.yamlworkflow that runsmake checkand additional validation targets. - Configure concurrency for the new workflow to cancel in-progress PR runs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/functions.yaml | Skips running the functions workflow when only docs/metadata files change. |
| .github/workflows/ci-check.yaml | New CI workflow to run checks/lints and generated-artifact validations on push/PR. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Enhance the CI check workflow by adding paths-ignore for documentation markdown files and ownership files in both push and pull request triggers. This change prevents unnecessary CI runs when only non-code files are modified, streamlining the workflow.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3833 +/- ##
==========================================
- Coverage 57.03% 53.47% -3.57%
==========================================
Files 182 200 +18
Lines 21376 23441 +2065
==========================================
+ Hits 12191 12534 +343
- Misses 7953 9654 +1701
- Partials 1232 1253 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lkingland
added
ok-to-test
Closes #3634
Summary
paths-ignorefilters to bothpushandpull_requesttriggers in theFunctionsCI workflowdocs/**,**/*.md,CODEOWNERS,LICENSEMotivation
The
Functionsworkflow spawns many expensive jobs (unit tests across 5 OSes, integration tests, 7-runtime E2E matrix). Running all of these on a docs-only commit wastes CI minutes and runner time.Test plan
.mdfile — verifyFunctionsworkflow is skipped.gofile — verifyFunctionsworkflow still runs