pkg/mcp: add tests for readonly enforcement, delete validation, and help resources

pkg/mcp/tools_delete_test.go

@@ -2,12 +2,88 @@ package mcp
 
 import (
 	"context"
+	"strings"
 	"testing"
 
 	"github.com/modelcontextprotocol/go-sdk/mcp"
 	"knative.dev/func/pkg/mcp/mock"
 )
 
+// TestTool_Delete_Readonly ensures the delete tool returns the readonly-mode
+// error when the server is in readonly mode.
+func TestTool_Delete_Readonly(t *testing.T) {
+	client, _, err := newTestPairWithReadonly(t, true)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	result, err := client.CallTool(t.Context(), &mcp.CallToolParams{
+		Name:      "delete",
+		Arguments: map[string]any{"name": "my-function"},
+	})
+	if err != nil {
+		t.Fatal(err)
+	}
+	if !result.IsError {
+		t.Fatal("expected error result for readonly server, got success")
+	}
+	got := result.Content[0].(*mcp.TextContent).Text
+	if !strings.Contains(got, "readonly mode") {
+		t.Fatalf("expected readonly-mode error, got: %q", got)
+	}
+}
+
+// TestTool_Delete_BothPathAndName ensures the delete tool returns a mutual-
+// exclusion validation error when both path and name are provided.
+func TestTool_Delete_BothPathAndName(t *testing.T) {
+	client, _, err := newTestPair(t)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	result, err := client.CallTool(t.Context(), &mcp.CallToolParams{
+		Name: "delete",
+		Arguments: map[string]any{
+			"path": "/some/path",
+			"name": "my-function",
+		},
+	})
+	if err != nil {
+		t.Fatal(err)
+	}
+	if !result.IsError {
+		t.Fatal("expected error result when both path and name are provided, got success")
+	}
+	got := result.Content[0].(*mcp.TextContent).Text
+	if !strings.Contains(got, "exactly one of 'path' or 'name'") {
+		t.Fatalf("expected mutual-exclusion validation error, got: %q", got)
+	}
+}
+
+// TestTool_Delete_NeitherPathNorName ensures the delete tool returns a mutual-
+// exclusion validation error when neither path nor name is provided.
+func TestTool_Delete_NeitherPathNorName(t *testing.T) {
+	client, _, err := newTestPair(t)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	result, err := client.CallTool(t.Context(), &mcp.CallToolParams{
+		Name:      "delete",
+		Arguments: map[string]any{},
+	})
+	if err != nil {
+		t.Fatal(err)
+	}
+	if !result.IsError {
+		t.Fatal("expected error result when neither path nor name is provided, got success")
+	}
+	got := result.Content[0].(*mcp.TextContent).Text
+	if !strings.Contains(got, "exactly one of 'path' or 'name'") {
+		t.Fatalf("expected mutual-exclusion validation error, got: %q", got)
+	}
+}
+
 // TestTool_Delete_Args ensures the delete tool executes with all arguments passed correctly.
 func TestTool_Delete_Args(t *testing.T) {
 	// Test data - defined once and used for both input and validation
@@ -76,22 +152,3 @@ func TestTool_Delete_Args(t *testing.T) {
 		t.Fatal("executor was not invoked")
 	}
 }
-
-// TestTool_Delete_Readonly ensures the delete tool rejects requests in readonly mode.
-func TestTool_Delete_Readonly(t *testing.T) {
-	client, _, err := newTestPairWithReadonly(t, true) // readonly = true
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	result, err := client.CallTool(t.Context(), &mcp.CallToolParams{
-		Name:      "delete",
-		Arguments: map[string]any{"name": "my-function"},
-	})
-	if err != nil {
-		t.Fatal(err)
-	}
-	if !result.IsError {
-		t.Fatal("expected delete to be rejected in readonly mode")
-	}
-}

pkg/mcp/tools_deploy_test.go

@@ -2,12 +2,37 @@ package mcp
 
 import (
 	"context"
+	"strings"
 	"testing"
 
 	"github.com/modelcontextprotocol/go-sdk/mcp"
 	"knative.dev/func/pkg/mcp/mock"
 )
 
+// TestTool_Deploy_Readonly ensures the deploy tool returns the readonly-mode
+// error when the server is in readonly mode.
+func TestTool_Deploy_Readonly(t *testing.T) {
+	client, _, err := newTestPairWithReadonly(t, true)
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	result, err := client.CallTool(t.Context(), &mcp.CallToolParams{
+		Name:      "deploy",
+		Arguments: map[string]any{"path": "."},
+	})
+	if err != nil {
+		t.Fatal(err)
+	}
+	if !result.IsError {
+		t.Fatal("expected error result for readonly server, got success")
+	}
+	got := result.Content[0].(*mcp.TextContent).Text
+	if !strings.Contains(got, "readonly mode") {
+		t.Fatalf("expected readonly-mode error, got: %q", got)
+	}
+}
+
 // TestTool_Deploy_Args ensures the deploy tool executes with all arguments passed correctly.
 func TestTool_Deploy_Args(t *testing.T) {
 	// Test data - defined once and used for both input and validation
@@ -79,22 +104,3 @@ func TestTool_Deploy_Args(t *testing.T) {
 		t.Fatal("executor was not invoked")
 	}
 }
-
-// TestTool_Deploy_Readonly ensures the deploy tool rejects requests in readonly mode.
-func TestTool_Deploy_Readonly(t *testing.T) {
-	client, _, err := newTestPairWithReadonly(t, true) // readonly = true
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	result, err := client.CallTool(t.Context(), &mcp.CallToolParams{
-		Name:      "deploy",
-		Arguments: map[string]any{"path": "."},
-	})
-	if err != nil {
-		t.Fatal(err)
-	}
-	if !result.IsError {
-		t.Fatal("expected deploy to be rejected in readonly mode")
-	}
-}