Skip to content

docs(mcp): fix delete tool instructions — no-args CWD mode not supported#3824

Open
Ankitsinghsisodya wants to merge 1 commit into
knative:mainfrom
Ankitsinghsisodya:fix/mcp-delete-instructions-cwd
Open

docs(mcp): fix delete tool instructions — no-args CWD mode not supported#3824
Ankitsinghsisodya wants to merge 1 commit into
knative:mainfrom
Ankitsinghsisodya:fix/mcp-delete-instructions-cwd

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

@Ankitsinghsisodya Ankitsinghsisodya commented May 21, 2026

Note: Re-submission of #3764, accidentally closed when the head repository was deleted.

Problem

The embedded MCP instructions at pkg/mcp/instructions.md stated:

"no named parameter indicates 'delete the Function in my cwd'"

This implied that agents could call the delete tool with no path and no name, and the tool would delete the Function in the current working directory.

That is incorrect in the MCP context. The MCP server runs as a separate process with its own working directory, unrelated to the Function the agent is managing. The handler at pkg/mcp/tools_delete.go correctly enforces that exactly one of path or name must be provided, returning an error otherwise.

The result was a direct contradiction between two lines in the same file, causing agents following the incorrect guidance to send requests the handler would reject.

Fix

Updated the description to accurately reflect the handler's contract: delete requires exactly one of path or name and does not support a no-argument CWD mode.

No code changes are needed. The handler behavior is correct.

Files changed

  • pkg/mcp/instructions.md — corrected description of the delete tool

Clarified that the `delete` tool now requires exactly one of `path` or `name`, removing the previous no-argument CWD mode. This change enhances the accuracy of the documentation regarding the tool's functionality.
Copilot AI review requested due to automatic review settings May 21, 2026 11:19
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya
Once this PR has been reviewed and has the lgtm label, please assign matejvasek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos May 21, 2026 11:19
@knative-prow knative-prow Bot added size/XS 🤖 PR changes 0-9 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels May 21, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 21, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates MCP documentation to clarify delete tool argument requirements and remove the previously documented implicit “delete in my cwd” mode.

Changes:

  • Clarifies that delete requires exactly one of path or name
  • Documents that a no-argument CWD-based delete mode is not supported due to MCP server process working directory semantics

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/mcp/instructions.md
**Exceptions:**
- The `list` tool operates on the cluster, not local files, so it does NOT use a path parameter (it uses namespace instead)
- The `delete` tool can accept an optional named Function to delete, in which case the path is not necessary (no named parameter indicates 'delete the Function in my cwd')
- The `delete` tool requires exactly one of `path` or `name`; it does NOT support a no-argument CWD mode (the MCP server process has its own working directory unrelated to the Function being managed)
@lkingland lkingland added ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test 🤖 Needs an org member to approve testing labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test 🤖 Non-member PR verified by an org member that is safe to test. size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants