fix(k8s): guard against nil vol.Path in ProcessVolumes

[Elvand-Lie]

Problem

ProcessVolumes in pkg/k8s/deployer.go dereferences vol.Path (*string) at line 925 without a nil check. If a Volume entry has a source type (secret, configMap, PVC) but no path field set, the nil pointer dereference crashes the process.

validateVolumes does detect a nil Path but returns []string (not error), and none of the callers of ProcessVolumes (k8s deployer, knative deployer) gate on validateVolumes before calling it.

Fix

Added a nil guard for vol.Path before the dereference block that returns a descriptive error instead of panicking.

Tests added

• Test_ProcessVolumes_NilPath: secret volume with nil path returns error
• Test_ProcessVolumes_NilPathConfigMap: configMap volume with nil path returns error
• Test_ProcessVolumes_ValidPath: valid volume with path works correctly

Fixes #3796

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elvand-Lie
Once this PR has been reviewed and has the lgtm label, please assign matejvasek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow]

Hi @Elvand-Lie. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.45%. Comparing base (ad6edb6) to head (6f981e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3805      +/-   ##
==========================================
+ Coverage   53.42%   53.45%   +0.03%     
==========================================
  Files         200      200              
  Lines       23426    23429       +3     
==========================================
+ Hits        12515    12524       +9     
+ Misses       9655     9649       -6     
  Partials     1256     1256              

Flag	Coverage Δ
e2e	33.68% <0.00%> (-0.02%)	⬇️
e2e go	29.64% <0.00%> (-0.01%)	⬇️
e2e node	25.86% <0.00%> (-0.01%)	⬇️
e2e python	29.97% <0.00%> (-0.01%)	⬇️
e2e quarkus	25.97% <0.00%> (-0.01%)	⬇️
e2e rust	25.43% <0.00%> (-0.02%)	⬇️
e2e springboot	24.11% <0.00%> (-0.01%)	⬇️
e2e typescript	25.96% <0.00%> (-0.01%)	⬇️
e2e-config-ci	26.75% <0.00%> (-0.01%)	⬇️
integration	15.63% <0.00%> (+<0.01%)	⬆️
unit macos-14	42.42% <100.00%> (+0.22%)	⬆️
unit macos-latest	42.42% <100.00%> (+0.22%)	⬆️
unit ubuntu-24.04-arm	42.71% <100.00%> (+0.20%)	⬆️
unit ubuntu-latest	43.28% <100.00%> (+0.22%)	⬆️
unit windows-latest	42.46% <100.00%> (+0.22%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.