fix: resolve product archive generation failures caused by bad p2.inf chmod and spurious pom.xml execution

[Copilot]

Two separate issues prevented all product archives from being generated, causing all CI artifact upload steps to report "No files were found".

Root causes & fixes

1. p2.inf chmod failed on Linux/macOS (features/example.rcp.feature.touchpoint/p2.inf)

The install touchpoint tried to chmod both script.bat and script.sh on every platform. Since script.bat is only installed on Windows (via per-OS rootfiles in build.properties), the ChmodAction threw on Linux/macOS:

The action chmod failed - file script.bat does not exist

Fix: Scope the install instruction to Unix platforms only and drop the script.bat chmod (Windows .bat files don't need execute bits):

# before
instructions.install = \
    chmod(targetDir:${installFolder},targetFile:script.bat,permissions:755);\
    chmod(targetDir:${installFolder},targetFile:script.sh,permissions:755);

# after
instructions.install.filter = (|(osgi.os=linux)(osgi.os=macosx))
instructions.install = \
    chmod(targetDir:${installFolder},targetFile:script.sh,permissions:755);

2. Spurious archive-products execution in root pom.xml

A prior change added an archive-products execution to the tycho-p2-director-plugin in the root pom.xml. Because the root project (packaging: pom) has no .product files, Tycho failed immediately:

Product with id 'example.rcp.app.ui.feature.product' does not exist in the project

Fix: Removed the <executions> block. The root pom.xml entry for tycho-p2-director-plugin is configuration-only (product IDs, archive names, root folders); Tycho's pomless build automatically runs archive-products in the releng/products submodule where the .product files live.

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[peterkir]

@copilot check the validation build ...
https://github.com/klibio/example.pde.rcp/actions/runs/22570692714/job/65378954625?pr=20
no artifacts are uploaded

[Copilot]

@copilot check the validation build ...
https://github.com/klibio/example.pde.rcp/actions/runs/22570692714/job/65378954625?pr=20
no artifacts are uploaded

The build was failing due to a broken p2.inf in the touchpoint feature — the chmod action used the old targetFile:${installFolder}/script.sh syntax, but Tycho 5.x's ChmodAction requires targetDir and targetFile as separate parameters. That failure prevented any products from being materialized, so there was nothing to upload.

Fixed in commit 106be3d:

• features/example.rcp.feature.touchpoint/p2.inf: changed chmod(targetFile:${installFolder}/script.sh,...) → chmod(targetDir:${installFolder},targetFile:script.sh,...)
• features/example.rcp.feature.touchpoint/build.properties: uncommented the linux and macosx rootfile entries so script.sh is actually included in those platform products