Render news item preview images using image_scales#3
Open
davisagli wants to merge 2 commits into
Open
Conversation
reekitconcept
approved these changes
Jun 28, 2023
Member
reekitconcept
left a comment
reekitconcept
left a comment
There was a problem hiding this comment.
ok looks good, I'll merge this asap
By the way why are the acceptance failing?
reekitconcept
force-pushed
the
ree-solr-support
branch
5 times, most recently
from
f991b04 to
221deb6
Compare
Member
|
Hi @davisagli , sorry I forgot about this, but I would like to make sure that this makes into the upcoming release. Since then on main branch I've updated the result types so they use the new image component, as well as there is a polyfill for Volto < 17, which we actually use in some project that is still on Plone 5.5. However the reducer does not contain yet the image scales. - That is still missing in main to allow it to work properly, correct? When you have a chance, could you update the PR to work on current main branch? Thanks and again sorry for keeping it stale for so long. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Once plone/volto#3337 is merged to volto core, we can update this to use the
Imagecomponent instead ofimg.